[#13129] - changing en-US color to default en-GB colour
- Fixed in Code Base
- 8 Dec 2016
- Medium
- Build: staging
- # 13129
- Diff
- MATsxm:patch-2
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
changing en-US color to default en-GB colour
Testing Instructions
on review
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings |
If it code it should be background-color but if it is narrative it should be Background colour, in my view
So which one is it Hils if it is text describing code?
When it is readable text for the user then 'colour' is to be used as
suggested in the PR.
Had it been a code value/text that the user had to enter in for example a
style override then it would need to use code standard 'color'
On Thu, Dec 8, 2016 at 1:50 PM, Brian Teeman notifications@github.com
wrote:
So which one is it Hils if it is text describing code?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#13129 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAwPrYEvPiNOinq-yC-UQ0JIO0Qj6gphks5rF_z4gaJpZM4LHuVd
.
It's just describing what happens if a button is pushed isn't it? If so colour should be the way to go in Joomla.
Ok. Fine by me. As I said I was undecided on this one I am happy to go with
the majority
On 8 Dec 2016 1:15 p.m., "Hils" notifications@github.com wrote:
It's just describing what happens if a button is pushed isn't it? If so
colour should be the way to go in Joomla.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#13129 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8e0Q5_XaoFWVdRydC8vH28RUSLkkks5rGAMDgaJpZM4LHuVd
.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13129.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13129.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13129.
| Milestone |
Added: |
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-08 17:07:01 |
| Closed_By | ⇒ | wilsonge | |
| Labels |
Added:
?
|
||
I am a little torn on this one. On the one hand you are perfectly correct and it should have a U. On the other hand it is referring to a code element called color so it is correct without the U.
(and to make it more fun we already use the U for a similar field in the template styles)