? ? Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
7 Dec 2016

Check that the fields uses the word values and not options in the label and the description and the capitalisation of the labels and that the strings are in sync in the front end and the admin

15b2991 7 Dec 2016 avatar brianteeman sync
avatar brianteeman brianteeman - open - 7 Dec 2016
avatar brianteeman brianteeman - change - 7 Dec 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Dec 2016
Category Administration Language & Strings
avatar brianteeman brianteeman - change - 7 Dec 2016
Title
lib.joomla.ini sync
[com_fields] lib.joomla.ini sync
avatar brianteeman brianteeman - change - 7 Dec 2016
Title
lib.joomla.ini sync
[com_fields] lib.joomla.ini sync
avatar brianteeman brianteeman - edited - 7 Dec 2016
avatar brianteeman brianteeman - change - 7 Dec 2016
Labels Added: ? ?
avatar brianteeman brianteeman - change - 7 Dec 2016
Labels
Easy No Yes
09bb4fa 7 Dec 2016 avatar brianteeman typo
avatar brianteeman brianteeman - change - 7 Dec 2016
Labels
avatar jeckodevelopment
jeckodevelopment - comment - 7 Dec 2016

I have tested this item successfully on 09bb4fa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13116.

avatar jeckodevelopment jeckodevelopment - test_item - 7 Dec 2016 - Tested successfully
avatar Bakual Bakual - change - 7 Dec 2016
Milestone Added:
avatar Bakual Bakual - change - 7 Dec 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-07 20:51:13
Closed_By Bakual
avatar Bakual Bakual - close - 7 Dec 2016
avatar Bakual Bakual - merge - 7 Dec 2016
avatar Bakual Bakual - reference | b146035 - 7 Dec 16
avatar Bakual Bakual - merge - 7 Dec 2016
avatar Bakual Bakual - close - 7 Dec 2016
avatar brianteeman
brianteeman - comment - 7 Dec 2016

Thank you

avatar brianteeman brianteeman - head_ref_deleted - 7 Dec 2016
avatar ggppdk
ggppdk - comment - 8 Dec 2016

@brianteeman , @jeckodevelopment , @infograf768

This needs to be reverted, it is just plain wrong !

They are options, NOT "values" comprised of:

e.g. (value+label) , and in future for other fields you will have:
(value+label+property1+property2)

I was the one that had made this correction in a PR,
and now it is wrong (again)

The language string name was wrong,
but i had changed it at my older PR, i had kept it "VALUES" in the language string name
and only corrected the translation, changing "values" to be "options"

avatar brianteeman
brianteeman - comment - 8 Dec 2016

In the context they are values not options.

On 8 Dec 2016 9:11 a.m., "Georgios Papadakis" notifications@github.com
wrote:

@brianteeman https://github.com/brianteeman , @jeckodevelopment
https://github.com/jeckodevelopment , @infograf768
https://github.com/infograf768

This needs to be reverted it is just plain wrong !

They are options, NOT "values" comprised of:

e.g. (value+label) , and in future for other fields you will have:
(value+label+property1+property2)

I was the one that had made this correction in a PR,
and now it is wrong (again)

The language string name was wrong,
but i had changed it at my older PR, i had kept it "VALUES" in the
language string name
and only corrected the translation to be "values" to be "options"


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13116 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8WBW08lPSmNqU0l61fd1mMsrCo-Fks5rF8nIgaJpZM4LGnTe
.

avatar infograf768
infograf768 - comment - 8 Dec 2016

@laoneo @Bakual
Input welcome on this.

avatar ggppdk
ggppdk - comment - 8 Dec 2016

I will make a PR with a explanation / justification,
i ll including my above mentioned arguments and a couple of more arguments

and we can discuss it there, thanks

avatar laoneo
laoneo - comment - 8 Dec 2016

Technically they are options. But value is also not wrong. I think we can accept one or the other.

avatar Bakual
Bakual - comment - 8 Dec 2016

I don't mind and leave that decision to native speakers.
In the translations it can be named whatever suites the language.

avatar ggppdk
ggppdk - comment - 8 Dec 2016

But translations / translating is not relevant at all here

I think i have misguided you when i mentioned the "translations" above,

to say that i had changed it like this

JLIB_FORM_FIELD_PARAM_LIST_MULTIPLE_VALUES_DESC="The options of the list."

but i should have better done it like this this:

JLIB_FORM_FIELD_PARAM_LIST_OPTIONS_DESC="The options of the list."

thus changing also the language constant string too
... and then also updating the XML files too, that use it

avatar Bakual
Bakual - comment - 8 Dec 2016

I did understand you perfectly fine.
I'm with @laoneo and think both wording is valid.
I still think if a native english speaker says values fits more than options, then that counts more than what a Swiss guy like me says ?

If you want to do a PR and discuss that, make sure you do it in both lib.joomla.ini files (frontend and backend) as they need to be in sync.

avatar brianteeman
brianteeman - comment - 8 Dec 2016

In the joomla system the word options has a specific meaning - thats why it
is wrong to use it hear

On 8 December 2016 at 14:21, Thomas Hunziker notifications@github.com
wrote:

I did understand you perfectly fine.
I'm with @laoneo https://github.com/laoneo and think both wording is
valid.
I still think if a native english speaker says values fits more than
options, then that counts more than what a Swiss guy like me says ?

If you want to do a PR and discuss that, make sure you do it in both
lib.joomla.ini files (frontend and backend) as they need to be in sync.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13116 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8RAqhkD2nWpyXAuL4ks_vDCO65k_ks5rGBJ_gaJpZM4LGnTe
.

--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar brianteeman
brianteeman - comment - 8 Dec 2016

thats why it is also wrong for me to write hear when i meant here :(

On 8 December 2016 at 16:36, Brian Teeman brian@teeman.net wrote:

In the joomla system the word options has a specific meaning - thats why
it is wrong to use it hear

On 8 December 2016 at 14:21, Thomas Hunziker notifications@github.com
wrote:

I did understand you perfectly fine.
I'm with @laoneo https://github.com/laoneo and think both wording is
valid.
I still think if a native english speaker says values fits more than
options, then that counts more than what a Swiss guy like me says ?

If you want to do a PR and discuss that, make sure you do it in both
lib.joomla.ini files (frontend and backend) as they need to be in sync.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13116 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8RAqhkD2nWpyXAuL4ks_vDCO65k_ks5rGBJ_gaJpZM4LGnTe
.

--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar infograf768
infograf768 - comment - 9 Dec 2016

imho, we should use Options for the Label and Desc, and Value as it is now righfully in the popup.
Options mean at the same time a Text AND a Value.

screen shot 2016-12-09 at 10 03 10

Add a Comment

Login with GitHub to post a comment