User tests: Successful: Unsuccessful:
Check that the fields uses the word values and not options in the label and the description and the capitalisation of the labels and that the strings are in sync in the front end and the admin
Status | New | ⇒ | Pending |
Category | ⇒ | Administration Language & Strings |
Title |
|
Title |
|
Labels |
Added:
?
?
|
Labels | |||
Easy | No | ⇒ | Yes |
Labels |
Milestone |
Added: |
Status | Pending | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-07 20:51:13 |
Closed_By | ⇒ | Bakual |
Thank you
@brianteeman , @jeckodevelopment , @infograf768
This needs to be reverted, it is just plain wrong !
They are options, NOT "values" comprised of:
e.g. (value+label) , and in future for other fields you will have:
(value+label+property1+property2)
I was the one that had made this correction in a PR,
and now it is wrong (again)
The language string name was wrong,
but i had changed it at my older PR, i had kept it "VALUES" in the language string name
and only corrected the translation, changing "values" to be "options"
In the context they are values not options.
On 8 Dec 2016 9:11 a.m., "Georgios Papadakis" notifications@github.com
wrote:
@brianteeman https://github.com/brianteeman , @jeckodevelopment
https://github.com/jeckodevelopment , @infograf768
https://github.com/infograf768This needs to be reverted it is just plain wrong !
They are options, NOT "values" comprised of:
e.g. (value+label) , and in future for other fields you will have:
(value+label+property1+property2)I was the one that had made this correction in a PR,
and now it is wrong (again)
- HTML calls them options (see the select HTML tag)
- Drupal call thems options too :
https://www.drupal.org/node/325766The language string name was wrong,
but i had changed it at my older PR, i had kept it "VALUES" in the
language string name
and only corrected the translation to be "values" to be "options"—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13116 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8WBW08lPSmNqU0l61fd1mMsrCo-Fks5rF8nIgaJpZM4LGnTe
.
I will make a PR with a explanation / justification,
i ll including my above mentioned arguments and a couple of more arguments
and we can discuss it there, thanks
Technically they are options. But value is also not wrong. I think we can accept one or the other.
I don't mind and leave that decision to native speakers.
In the translations it can be named whatever suites the language.
But translations / translating is not relevant at all here
I think i have misguided you when i mentioned the "translations" above,
to say that i had changed it like this
JLIB_FORM_FIELD_PARAM_LIST_MULTIPLE_VALUES_DESC="The options of the list."
but i should have better done it like this this:
JLIB_FORM_FIELD_PARAM_LIST_OPTIONS_DESC="The options of the list."
thus changing also the language constant string too
... and then also updating the XML files too, that use it
I did understand you perfectly fine.
I'm with @laoneo and think both wording is valid.
I still think if a native english speaker says values fits more than options, then that counts more than what a Swiss guy like me says
If you want to do a PR and discuss that, make sure you do it in both lib.joomla.ini files (frontend and backend) as they need to be in sync.
In the joomla system the word options has a specific meaning - thats why it
is wrong to use it hear
On 8 December 2016 at 14:21, Thomas Hunziker notifications@github.com
wrote:
I did understand you perfectly fine.
I'm with @laoneo https://github.com/laoneo and think both wording is
valid.
I still think if a native english speaker says values fits more than
options, then that counts more than what a Swiss guy like me says? If you want to do a PR and discuss that, make sure you do it in both
lib.joomla.ini files (frontend and backend) as they need to be in sync.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13116 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8RAqhkD2nWpyXAuL4ks_vDCO65k_ks5rGBJ_gaJpZM4LGnTe
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
thats why it is also wrong for me to write hear when i meant here :(
On 8 December 2016 at 16:36, Brian Teeman brian@teeman.net wrote:
In the joomla system the word options has a specific meaning - thats why
it is wrong to use it hearOn 8 December 2016 at 14:21, Thomas Hunziker notifications@github.com
wrote:I did understand you perfectly fine.
I'm with @laoneo https://github.com/laoneo and think both wording is
valid.
I still think if a native english speaker says values fits more than
options, then that counts more than what a Swiss guy like me says? If you want to do a PR and discuss that, make sure you do it in both
lib.joomla.ini files (frontend and backend) as they need to be in sync.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#13116 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8RAqhkD2nWpyXAuL4ks_vDCO65k_ks5rGBJ_gaJpZM4LGnTe
.--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
I have tested this item✅ successfully on 09bb4fa
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13116.