[#13112] - Multilanguage: correcting saving menu item with same alias when language is changed to ALL
- Fixed in Code Base
- 11 Dec 2016
- Medium
- Build: staging
- # 13112
- Diff
- infograf768:multi_alias_all
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Making a new menu item set to ALL or changing an existing menu item to ALL act differently when the same alias already exists (at Root).
Testing Instructions
On a multingual site, one can use the same alias for menu items in the root of their specific language as long as these menu items are tagged to the specific different languages, NOT including All.
i.e one can have mysite.com/en/isaacnewton and mysite,com/fr/isaacnewton.
To test, create a simple multilingual site
Create in fr-FR a menu item with the alias isaacnewton tagged to fr-FR at the root of the menu.
Create in an en-GB menu a menu item tagged to ALL with the same alias isaacnewton at the root of the menu.
You can't save the menu item. All is good.
Now change the language to en-GB. It saves OK and that is fine.
Now, edit again that menu item and change its language to ALL: it is possible although it should NOT be!
Patch and test again.
In that specific case (changing to ALL), one will get the message:
Save failed with the following error: The alias search is already being used by the search menu item in another menu (remember it may be a trashed item).
We can't use the normal message as it could be confusing by containing the menutype while we change a menu item to ALL in the same menu type.
Documentation Changes Required
None. This is a bug
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Libraries |
There are several unrelated language changes in this PR ?
Indeed. The en-GB.lib_joomla.ini file were not in sync. The site one was missing some new strings added by com_fields in the admin one. I have corrected that too. Should have told it in the description.
Can we please just have one issue in a pr.
http://blog.ploeh.dk/2015/01/15/10-tips-for-better-pull-requests/
Adding unrelated issues in a PR are a guaranteed way to create issues
On 7 December 2016 at 09:19, infograf768 notifications@github.com wrote:
Indeed. The en-GB.lib_joomla.ini file were not in sync. The site one was
missing some new strings added by com_fields in the admin one. I have
corrected that too. Should have told it in the description.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#13112 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8cj2lkdE8UGnJd-SU-syPCGjfFS4ks5rFno3gaJpZM4LGS_M
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
This will not create issues at all. I suggest you rather test the PR. Thanks.
Thats not the point and no I wont
On 7 December 2016 at 09:22, infograf768 notifications@github.com wrote:
This will not create issues at all. I suggest you rather test the PR.
Thanks.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#13112 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8bVLT8z7aNY3Tgh7ZwPslR4sN3bUks5rFnrwgaJpZM4LGS_M
.
--
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
| Labels |
Added:
?
?
|
||
@infograf768 see infograf768#48
We can't use the normal message as it could be confusing by containing the menutype while we change a menu item to ALL in the same menu type.
atually we do that in now also in non multilang sites so i don't see an issue to continue with the same message.
| Category | Administration Language & Strings Libraries | ⇒ | Libraries |
| Labels |
Removed:
?
|
||
@bembelimen @alikon
Please test.
| Category | Libraries | ⇒ | Libraries Multilanguage |
I have tested this item
Patch ok.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13112.
I have tested this item
Works for me nice job
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13112.
| Status | Pending | ⇒ | Ready to Commit |
rtc. thanks
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13112.
zero-24
- | Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-11 10:44:12 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
cpfeifer
-
@bembelimen @andrepereiradasilva @alikon
Thank you for testing.
Any simplification welcome.