Joomla! Issue Tracker | Joomla! CMS #13093 - Render only the input when no fieldsets are specified in subform layouts

Fixed in Code Base
23 Dec 2016
Medium
Build: staging
Easy Test
# 13093
Diff
Digital-Peak:subform-smaller-table

Success

Success continuous-integration/drone the build was successful Details
Success continuous-integration/travis-ci/pr The Travis CI build passed Details
Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details

User tests: Successful: Unsuccessful:

laoneo
5 Dec 2016

Pull Request for PR #13069.

Summary of Changes

The label of the field is show in the table layout of the subform field as column header and then inline before the input field
This PR shows the label beside the input field only when the fields itself should be grouped by its groups.

Testing Instructions

Put the following XML code into the file administrator/components/com_content/models/forms/article.xml after line 162 (inside the basic fieldset in the attribs tag).

<field name="demo" type="subform" label="Subform" multiple="true" layout="joomla.form.field.subform.repeatable-table">
	<form>
		<field name="name"
			label="Name"
			size="30" type="text" />

		<field name="value"
			label="Value"
			size="30" type="text" />
	</form>
</field>

Expected result

The labels should not be shown in the cell, like

Actual result

The labels are shown.

laoneo - open - 5 Dec 2016

laoneo - change - 5 Dec 2016

Status

New

⇒

Pending

joomla-cms-bot - change - 5 Dec 2016

Category

⇒

Layout

brianteeman - comment - 7 Dec 2016

I have tested this item ✅ successfully on eac64ae

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13093.}

brianteeman - test_item - 7 Dec 2016 - Tested successfully

brianteeman - change - 8 Dec 2016

Easy

⇒

Yes

Fedik - comment - 8 Dec 2016

now I remember why was need $field->renderField(), it need for showon feature,

maybe we can do something like $field->renderField(array('label' => false)),
but cannot check currently

ralain - comment - 8 Dec 2016

I have tested this item ✅ successfully on eac64ae

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13093.}

ralain - test_item - 8 Dec 2016 - Tested successfully

jeckodevelopment - change - 9 Dec 2016

Status

Pending

⇒

Ready to Commit

jeckodevelopment - comment - 9 Dec 2016

Rtc

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13093.}

Fedik - comment - 9 Dec 2016

please hold on,
need to test showon feature,
for it can use xml from #12511 with layout="joomla.form.field.subform.repeatable-table" or:

<field name="items" type="subform"  multiple="true"  label="Subform Field" 
layout="joomla.form.field.subform.repeatable-table" >
  <form>
    <field name="type" type="list" default="0" label="Type" >
        <option value="0">Small</option>
        <option value="1">Medium</option>
        <option value="2">Large</option>
       </field>

        <field name="something"  type="text"
            label="Show when Type=Large" showon="type:2" />
   </form>
</field>

I cannot currently, maybe this evening or tomorrow

laoneo - comment - 9 Dec 2016

Just tested it and showon is not working. Thanks for having a look @Fedik !!

brianteeman - change - 9 Dec 2016

Milestone

Added:

jeckodevelopment - change - 9 Dec 2016

Status

Ready to Commit

⇒

Pending

joomla-cms-bot - change - 9 Dec 2016

Milestone

Removed:

Fedik - comment - 10 Dec 2016

hm, $field->renderField(array('hiddenLabel' => true)); partially do the thing,
but default Joomla! styling add .form-horizontal .controls {margin-left: 180px;} for input.
No idea what the best solution here

laoneo - comment - 13 Dec 2016

@Fedik resetting the margin left with b83801e, what do you think?

Fedik - comment - 13 Dec 2016

looks as good idea ?

laoneo - comment - 15 Dec 2016

Can this being tested again, with the following XML code, thanks!!

<field name="items" type="subform"  multiple="true"  label="Subform Field"
	layout="joomla.form.field.subform.repeatable-table" >
	<form>
		<field name="type" type="list" default="0" label="Type" >
			<option value="0">Small</option>
			<option value="1">Medium</option>
			<option value="2">Large</option>
		</field>
		<field name="something"  type="text"
			label="Show when Type=Large" showon="type:2" />
	</form>
</field>

The show on functionality should work as well.

ralain - comment - 18 Dec 2016

@laoneo Left margin reset isn't working right now because the data-group attribute is being modified when we insert rows. Perhaps target data-base-name, instead? That should be the same for each row.

Fedik - comment - 18 Dec 2016

I have tested and it not realy work, @ralain are right,
but there one more thing, this code add CSS multiple times.
So maybe better place:

JFactory::getDocument()->addStyleDeclaration(
  '.subform-repeatable-group[data-base-name="' . $fieldname . '"] .controls { margin-left: 0px }'
);

in the repeatable-table.php somewhere after this line repeatable-table.php#L62

Other possible solution is to add specific class to <div class="subform-repeatable-wrapper subform-table-layout"> and use CSS file to styling:

<div class="subform-repeatable-wrapper subform-table-layout subform-table-sublayout-<?php echo $sublayout; ?>">

and in css:

.subform-table-sublayout-section .controls { margin-left: 0px }

ralain - comment - 18 Dec 2016

Other possible solution is to add specific class to <div class="subform-repeatable-wrapper subform-table-layout"> and use CSS file to stylig.

Indeed, I would personally prefer a single global css rule over the embedded styles, if possible.

fe8a25d 21 Dec 2016

Render only the input when no fieldsets are specified in subform layouts

da652ef 21 Dec 2016

Reset margin left, because we don't have a label

944b382 21 Dec 2016

Better selector

laoneo - comment - 21 Dec 2016

Changed to your suggestion, thanks for your help, much appreciated.

Fedik - comment - 21 Dec 2016

only, please move addStyleDeclaration() in to the repeatable-table.php somewhere after this line repeatable-table.php#L62 , because in current place it will be added multiple times

1e872d4 22 Dec 2016

Merge branch 'staging' into subform-smaller-table

027030e 22 Dec 2016

Move CSS margin reset to the main layout

a272243 22 Dec 2016

Read missing new line

laoneo - comment - 22 Dec 2016

Done, should work now

laoneo - comment - 23 Dec 2016

Can we have another round of testing please. Thanks.

zero-24 - change - 23 Dec 2016

Milestone

Added:

Fedik - comment - 23 Dec 2016

I have tested this item ✅ successfully on a272243

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13093.}

Fedik - test_item - 23 Dec 2016 - Tested successfully

ralain - comment - 23 Dec 2016

I have tested this item ✅ successfully on a272243

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13093.}

ralain - test_item - 23 Dec 2016 - Tested successfully

joomla-cms-bot - change - 23 Dec 2016

Milestone

Removed:

jeckodevelopment - change - 23 Dec 2016

Status

Pending

⇒

Ready to Commit

jeckodevelopment - comment - 23 Dec 2016

RTC

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13093.}

jeckodevelopment - change - 23 Dec 2016

Milestone

Added:

zero-24 - reference | eb5d85f - 23 Dec 16

zero-24 - merge - 23 Dec 2016

zero-24 - close - 23 Dec 2016

zero-24 - change - 23 Dec 2016

Status	Ready to Commit	⇒	Fixed in Code Base
Closed_Date	0000-00-00 00:00:00	⇒	2016-12-23 16:57:35
Closed_By		⇒	zero-24
Labels	Added: ?

zero-24 - close - 23 Dec 2016

zero-24 - merge - 23 Dec 2016

zero-24 - comment - 23 Dec 2016

Merged thanks

Add a Comment

Older
Newer

Joomla! Issue Tracker - CMS

[#13093] - Render only the input when no fieldsets are specified in subform layouts

Summary of Changes

Testing Instructions

Expected result

Actual result

Add a Comment