Feeling Lucky
?
[#13089] - Fix register to read redirect
- Fixed in Code Base
- 6 Dec 2016
- Medium
- Build: staging
- Easy Test
- # 13089
- Diff
- Bakual:FixRegisterRedirect
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue ##12945 .
Summary of Changes
- Changes code so the return value passed in the request (eg from a readmore link) takes precedence over redirect settings from a menu item param.
- Removed the "fallback to profile view" code in the model. This is not needed since the controller does the same as well.
Testing Instructions
From original issue:
- Install a clean staging.
- Create an article set to registered with a Read More and set Show Unauthorised Links to Yes.
- Create a menu item to display that article and set Show Unauthorised Links to Yes.
- Create a Login Menu item which will display on the same page as the single article menu item.
- Add a login redirection to that login menu item to anything else that the single article menu item created above.
- Display the article in frontend.
- Click on the "Register to Read More..."
After login, it is expected to be redirected to the full article after this PR, prior you were redirected according to menu item settings.
Of course try other settings (eg no redirect set, regular login, ...)
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_users |
| Easy | No | ⇒ | Yes |
infograf768
- comment
- 5 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13089.
| Status | Pending | ⇒ | Ready to Commit |
infograf768
- comment
- 5 Dec 2016
Also tested on multilingual site.
Thanks!
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13089.
jeckodevelopment
- | Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-06 22:32:30 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 0472343
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13089.