Feeling Lucky
?
[#13081] - Fix regression in script render (async/defer attributes when directly modifying _scripts property)
- Fixed in Code Base
- 18 Dec 2016
- Medium
- Build: staging
- # 13081
- Diff
- andrepereiradasilva:patch-36
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
If an extension has acessing the JDocument::_scripts public property, with the changes in the script render it can now cause the script to add async and defer attributes, even if set to false.
This PR intends to correct that.
Testing Instructions
- Code review
- Add to your template index.php (protostar/isis)
$this->_scripts = array_merge(array('/test3.js' => array('mime' => 'text/javascript', 'defer' => '', 'async' => '')), $this->_scripts);
$this->_scripts = array_merge(array('/test2.js' => array('mime' => 'text/javascript', 'defer' => false, 'async' => false)), $this->_scripts);
$this->_scripts = array_merge(array('/test1.js' => array('mime' => 'text/javascript', 'defer' => true, 'async' => true)), $this->_scripts);- Notice the results are different in 3.6.4 and in 3.7.0 staging (which are incorrect).
<!-- 3.6.4 -->
<script src="/test1.js" defer async></script>
<script src="/test2.js"></script>
<script src="/test3.js"></script>
<!-- 3.7.0 -->
<script src="/test1.js" defer async></script>
<script src="/test2.js" defer async></script>
<script src="/test3.js" defer async></script>- Apply patch, notice the results on 3.7.0 staging are now the same as 3.6.4
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Milestone |
Added: |
||
dgt41
- comment
- 18 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13081.
waader
- comment
- 18 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13081.
| Milestone |
Removed: |
||
| Status | Pending | ⇒ | Ready to Commit |
dgt41
- comment
- 18 Dec 2016
RTC
Thanks @andrepereiradasilva
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-18 15:11:18 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
zero-24
- comment
- 18 Dec 2016
Thanks
cpfeifer
-
can anyone please test this?
@wilsonge @zero-24 maybe a release blocker here?