Feeling Lucky
?
?
[#13074] - Lazy session starting
- Fixed in Code Base
- 19 Dec 2016
- Medium
- Build: staging
- # 13074
- Diff
- mbabker:lazy-session-start
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This is only the lazy session starting code from #10905.
JSessioncan now lazy start a session; calls toget(),set(),has(), andclear()will start the session if it hasn't explicitly been started previously- The application classes are restructured to not explicitly start the session; this defers the point
JSession::start()is called from the application constructors to one of the first actions done after$app->execute()is called. The advantage here is that now sessions are started after the application has been instantiated and set toJFactory::$application, meaning a session startup error should result in a real error page instead of the plain "Application Instantiation Error" message.
Testing Instructions
Sessions should continue to work just fine, #12108 should not be reintroduced.
Documentation Changes Required
N/A
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation Libraries |
| Labels |
Added:
?
|
||
| Category | Installation Libraries | ⇒ | Installation Libraries Unit Tests |
mbabker
- comment
- 3 Dec 2016
Yep, this was the set of changes that needed the added session mocks in the tests from the old PR. Since Joomla has a lovely deep rooted set of inter-dependencies.
wilsonge
- comment
- 8 Dec 2016
I've cherry-picked the test fixes into staging :) They were clearly correct
andrepereiradasilva
- comment
- 18 Dec 2016
I have tested this item
installed patach login/logout on both site and admin, and with or without shared sessions (database sessions).
all worked fine and no php warning
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13074.
dgt41
- comment
- 18 Dec 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13074.
| Milestone |
Added: |
||
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-19 14:51:11 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
cpfeifer
-
Hmm travis fails here?