[#13069] - [com_fields] Migrate from repeatable to subform field for list options
- Fixed in Code Base
- 15 Dec 2016
- Medium
- Build: staging
- Easy Test
- # 13069
- Diff
- Digital-Peak:subform-list
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
As the repeatable form field is deprecated we need to migrate the custom fields list options to a subform field.
What needs to be discussed is the layout of the subform to choose, any suggestions which one would be best? Pinging here @coolcat-creations and @ciar4n.
Till #12813 got merged, you need to apply that patch first.
Testing Instructions
- Create a list field
- Edit an article and choose some values
- Open the article on the front
Expected result
All should work the same as without the patch. The only things which changes is that a subform field is shown when entering the list options.
Actual result
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_fields Libraries |
| Labels |
Removed:
?
|
||
It looks good on big screens, but as soon as it becomes smaller than 1500 pixels, it get stacked
@laoneo thats a bug in the template that we have in many places :(
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13069.
That one uses too much space. I'm close to make a new one which uses the default, but puts the name and keys on one line.
I wondered why do you have: "label input" in the table cell, it should be just: "input",
when groupByFieldset="false" (that is default), then the table width would be twice smaller
hm, ok, there should be <?php echo $field->input; ?> instead of <?php echo $field->renderField(); ?>
Done, thanks for the hint.
| Easy | No | ⇒ | Yes |
I have tested this item
After applying the patch I get the following error when opening an article
Warning: Invalid argument supplied for foreach() in /libraries/joomla/form/abstractlist.php on line 220
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13069.
Did you test it on a fresh installation? Because the structure has changed, so old data which was created before the patch becomes invalid and can produce that error.
It should have been but I will retest later
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13069.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13069.
Can we set this one to RTC? This needs to come into the first alpha, we don't want to use a deprecated form field.
| Status | Pending | ⇒ | Ready to Commit |
RTC
rdeutz
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-15 16:10:52 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
cpfeifer
-
Your changes in libraries/joomla/form/abstractlist.php
for method: getOptionsFromField()
effect 3 fields: list, radio, checkboxes
(they extend the class and also use the method)
and you only updated the list field,
the other 2 fields are now broken, e.g. broken in edit form