[#13053] - Check if batchSelector is defined.
- Fixed in Code Base
- 6 Dec 2016
- Medium
- Build: staging
- # 13053
- Diff
- Bakual:ImproveJavaScriptBatchCode
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
In PR #13019 (comment) an issue was detected which is technically not related to that PR, thus I do an own one.
If you have a batch modal without a category/position/menu selector but have the copy/move radios, you will get a JavaScript error in the console.
That is because someone introduced that code in a lazy way and added it to the JLayout for the language field, and not for the one rendering the category/position/menu selects with the copy/move radios.
Now if you have your own select with those radios like in the mentioned PR, the JavaScript tries to run with an undefined batchSelector variable.
Summary of Changes
This PR just adds a simple check if the variable has some content, otherwise the code will not do anything.
Another approach would be to move the code to the correct JLayouts, but that can be seen as not B/C.
Testing Instructions
Simplest test would be to apply PR #13019, check the console output in the fields view. You'll see the error. Apply this PR here as well and the error will be gone. Not sure if that is possible with the Patchtester.
Another test is to make sure any batch modals (eg the articles one) still show/hide the copy/move radios when selecting/unselecting a category in the batch modal.
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Layout |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13053.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13053.
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-06 22:28:39 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 7802985
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13053.