[#13049] - RTL: correcting image popup display
- Fixed in Code Base
- 6 Dec 2016
- Medium
- Build: staging
- # 13049
- Diff
- infograf768:RTL_image_popup
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Testing Instructions
Set en-GB.xml to rtl
In frontend as in backend, click to select an image in a form.
The popup has to be less than 767px wide.
The popup displays only as LTR (folders at left, margin too).
Before patch:
After patch
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_media |
| Category | Administration com_media | ⇒ | Administration com_media RTL |
| Labels |
Removed:
?
|
||
I have tested this item
Tested this patch successfully.
Not related to this specific patch, but the margins for the "Cancel" and "Insert" button are different between RTL and LTR.
Even without applying this patch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13049.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13049.
| Milestone |
Added: |
||
Not related to this specific patch, but the margins for the "Cancel" and "Insert" button are different between RTL and LTR.
Yep, I already saw that. Could not solve here.
The issue comes from this css
.row {
margin-left: -20px;
}It can be solved easily for Isis as we have a real template_rtl.css but not for Protostar where we use an erzatz of RTL.
In Isis we just have to use in the rtl.less and it will be forwarded to the rtl_.css:
#imageForm .row {
margin-left: 10px;
*zoom: 1;
}But if I use in Isis
.row {
margin-left: 10px;
*zoom: 1;
}and in Protostar
.rtl .row {
margin-left: 10px;
*zoom: 1;
}We may get undesired consequences.
The media/jui/less/bootstrap-rtl.less file provided by core is fatally broken. #12023 points out my main issue with it and in looking into a fix for our joomla.org site template I found that our RTL LESS is just fundamentally flawed and cannot produce a correctly "flipped" variant of the template.
The toolbar has bad default CSS, see #12024
Bordered tables are busted too, see #12022
@infograf768 Relating to #12643 (comment) , Is there a reason this style declaration is not in the template.css and template-rtl.css ?
As far as I understood this is because it is used in the IFrame specifically for any template (backend or frontend)
For example, I tried to add them to the popup-imagelist.css and rtl and they will not work.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-06 11:30:38 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 8955085
I can confirm that this PR does what it says.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13049.