Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#13038] - Use JLanguageHelper::getContentLanguages in languagefilter and mod_languages

? Failure

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
27 Nov 2016

Summary of Changes

Use the new JLanguageHelper::getContentLanguages() in language filter plugin and mod_languages.

also:

  • add a fallback in JLanguageHelper::getContentLanguages() to en-GB language when no content language is published to avoid redirect loops when there is no content language. - This corrects a bug in language filter when all content languages are unpublished ... redirect loop.
  • moved content languages metadesc and keywords from site app to language filter after dispatch event (check if there are no issues with this)

Testing Instructions

Code review (https://github.com/joomla/joomla-cms/pull/13038/files?w=1 to review without whitespace changes)

  1. Use multilingual site and apply patch
  2. Confirm all language stuff works properly (add/remove content languages, change order, edit, etc and check the language filter and mod_languages work properly).
  3. Confirm content language sitename, description and metakeys works fine.

Documentation Changes Required

None.

pinging @alikon and @infograf768

avatar andrepereiradasilva andrepereiradasilva - open - 27 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 27 Nov 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2016
Category ⇒ Libraries Modules Front End Plugins
avatar andrepereiradasilva andrepereiradasilva - change - 27 Nov 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 27 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 27 Nov 2016
Title
…
Use the new JLanguageHelper::getContentLanguages in site app, languagefilter and mod_languages
Use JLanguageHelper::getContentLanguages in site app, languagefilter and mod_languages
avatar andrepereiradasilva andrepereiradasilva - edited - 27 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 27 Nov 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 27 Nov 2016
The description was changed
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - edited - 27 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 27 Nov 2016
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - change - 27 Nov 2016
The description was changed
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - edited - 27 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 27 Nov 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 27 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 27 Nov 2016
Labels Added: ?
avatar andrepereiradasilva
andrepereiradasilva - comment - 27 Nov 2016

@mbabker sorry to ask for your support again ? , but can you confirm the metadesc, metakey move from site app to language filter plugin is ok and B/C?

avatar andrepereiradasilva andrepereiradasilva - change - 27 Nov 2016
Title
…
Use JLanguageHelper::getContentLanguages in site app, languagefilter and mod_languages
Use JLanguageHelper::getContentLanguages in languagefilter and mod_languages
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - edited - 27 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 27 Nov 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 27 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 27 Nov 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 27 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 27 Nov 2016
The description was changed
avatar andrepereiradasilva andrepereiradasilva - edited - 27 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 11 Jan 2017
Labels Added: ?
avatar franz-wohlkoenig
franz-wohlkoenig - comment - 23 Sep 2018

If this Issue get no Response, it will be closed at 27th October 2018.

avatar joomla-cms-bot joomla-cms-bot - change - 27 Oct 2018
Closed_Date 2018-10-27 07:35:07 ⇒ 2018-10-27 07:35:08
Closed_By franz-wohlkoenig ⇒ joomla-cms-bot
avatar joomla-cms-bot joomla-cms-bot - close - 27 Oct 2018
avatar franz-wohlkoenig franz-wohlkoenig - change - 27 Oct 2018
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2018-10-27 07:35:07
Closed_By ⇒ franz-wohlkoenig
avatar joomla-cms-bot
joomla-cms-bot - comment - 27 Oct 2018

Set to "closed" on behalf of @franz-wohlkoenig by The JTracker Application at issues.joomla.org/joomla-cms/13038

avatar franz-wohlkoenig
franz-wohlkoenig - comment - 27 Oct 2018

Closed as stated above.

Add a Comment

Login with GitHub to post a comment