[#13030] - [4.0] com_menus: correct incomplete group by clause
- Fixed in Code Base
- 15 Jan 2017
- Medium
- Build: 4.0-dev
- # 13030
- Diff
- andrepereiradasilva:patch-41
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
If you enable associations in language filter 4.0 bracnh is producing an sql error because of the group by clause.
Related to the more strict ONLY_FULL_GROUP_BY sql_mode added in 4.0 branch (#12494)
Testing Instructions
Mainly code review, but you can also
- Use 4.0 branch
- Enable language filter plugin and associations
- Go to menus -> all menus you get an sql error
- Apply patch, no error
Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
Again without testing, and beside making sure that correct results are given by the modified group-by
The group-by is becoming very big
There must be better solutions than making the groub-by very big
The fact that we need some extra data and we join with tables to get them,
- this then forces us to add ALL non-aggregated columns into the Group-by because of ONLY_FULL_GROUP_BY
this really seems wasteful, the solution should be (i guess) to use a JOIN with a single subquery that will contain the group-by and which will group-by on a lot less columns ?
yes, i see,
the views need to work again and possibly revise the queries later,
then i only argue to make a list of the queries that had their group-by enlarged because of the new mode
well ... are being marked by this PRs
Can you rebase this one please?
zero-24
- | Milestone |
Added: |
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-15 15:18:50 |
| Closed_By | ⇒ | wilsonge |
Thanks :)
I have not tested this or the other similar PRs,
i only want to say, that fixing this is 2 parts