? Success

User tests: Successful: Unsuccessful:

avatar alikon
alikon
26 Nov 2016

Summary of Changes

correct tfoot colspan when count items active

Testing Instructions

in backend -> components -> tags
from search tools enable the tag type items count
tfoot

you should notice that the footer colspan is worng

apply the pacth
the footer colspan is ok
tfoot2

avatar alikon alikon - open - 26 Nov 2016
avatar alikon alikon - change - 26 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 26 Nov 2016
Category com_tags Administration
avatar brianteeman
brianteeman - comment - 26 Nov 2016

I have tested this item successfully on bae13f5


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13023.

avatar brianteeman brianteeman - test_item - 26 Nov 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 Nov 2016

Can you take a look at #12766
Looks the same issue. The code should be the same

(Sent from my phone)

avatar alikon
alikon - comment - 26 Nov 2016

yes,
the same issue fixed in 2 different style

avatar ggppdk
ggppdk - comment - 26 Nov 2016

I have tested this item successfully on bae13f5

Tested, did code review too


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13023.

avatar ggppdk ggppdk - test_item - 26 Nov 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 26 Nov 2016

@alikon for consistency and as the other was first can you change this to the other code style please

avatar alikon
alikon - comment - 26 Nov 2016

sure, done

avatar ggppdk
ggppdk - comment - 26 Nov 2016

I have tested this item successfully on 961ea2a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13023.

avatar ggppdk ggppdk - test_item - 26 Nov 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Nov 2016

I have tested this item successfully on 961ea2a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13023.

avatar andrepereiradasilva andrepereiradasilva - test_item - 26 Nov 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - change - 26 Nov 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 26 Nov 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13023.

avatar jeckodevelopment jeckodevelopment - change - 26 Nov 2016
Milestone Added:
avatar rdeutz rdeutz - change - 6 Dec 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-06 22:26:50
Closed_By rdeutz
avatar rdeutz rdeutz - close - 6 Dec 2016
avatar rdeutz rdeutz - merge - 6 Dec 2016
avatar rdeutz rdeutz - reference | f6046e5 - 6 Dec 16
avatar rdeutz rdeutz - merge - 6 Dec 2016
avatar rdeutz rdeutz - close - 6 Dec 2016
avatar alikon alikon - head_ref_deleted - 6 Dec 2016

Add a Comment

Login with GitHub to post a comment