? Success

User tests: Successful: Unsuccessful:

avatar Hackwar
Hackwar
25 Nov 2016

This removes the option for modern routing from the components configuration.

avatar Hackwar Hackwar - open - 25 Nov 2016
avatar Hackwar Hackwar - change - 25 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 25 Nov 2016
Category Administration com_contact
avatar Hackwar Hackwar - change - 25 Nov 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 25 Nov 2016
Category Administration com_contact Administration com_contact com_content
avatar joomla-cms-bot joomla-cms-bot - change - 25 Nov 2016
Category Administration com_contact com_content Administration com_contact com_content com_newsfeeds
avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Nov 2016

@Hackwar i think you also need to remove showon="sef_advanced:1" in sef ids field

avatar Hackwar
Hackwar - comment - 26 Nov 2016

Yes, you are right. Done.

avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Nov 2016

@Hackwar since 4.0 is a B/C break version shouldn't the default for sef_ids be 1 ?
Not sure what's the level of B/C allowed here ...

avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Nov 2016

I have tested this item successfully on de045c1

anyway this is not what this PR does, so tested with success on code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13021.

avatar andrepereiradasilva andrepereiradasilva - test_item - 26 Nov 2016 - Tested successfully
avatar Hackwar
Hackwar - comment - 26 Nov 2016

I don't want to remove the IDs by default. We are just using the modern routing in all cases, but otherwise that is just another option that people can select. So keeping that 0 is correct for me. 😄

avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Nov 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 26 Nov 2016

I have tested this item 🔴 unsuccessfully on de045c1

as comments above


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13021.

avatar andrepereiradasilva andrepereiradasilva - test_item - 26 Nov 2016 - Tested unsuccessfully
avatar joomla-cms-bot joomla-cms-bot - change - 27 Nov 2016
Category Administration com_contact com_content com_newsfeeds Administration com_contact com_content com_newsfeeds com_users
avatar Hackwar
Hackwar - comment - 27 Nov 2016

Removed the option in com_users, too.

avatar wilsonge wilsonge - reference | fd5aca5 - 18 Dec 16
avatar wilsonge wilsonge - merge - 18 Dec 2016
avatar wilsonge wilsonge - close - 18 Dec 2016
avatar wilsonge wilsonge - change - 18 Dec 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-18 11:43:26
Closed_By wilsonge
avatar wilsonge wilsonge - close - 18 Dec 2016
avatar wilsonge wilsonge - merge - 18 Dec 2016
avatar zero-24 zero-24 - change - 18 Dec 2016
Milestone Added:

Add a Comment

Login with GitHub to post a comment