[#13010] - Coding style. PHP constants true, false, and null MUST be in lower case.
- Fixed in Code Base
- 25 Nov 2016
- Medium
- Build: staging
- # 13010
- Diff
- marcochirienti:staging
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
The PHP keywords MUST be in lower case. The PHP constants true, false, and null MUST be in lower case.
See Joomla Coding Standards: https://github.com/joomla/coding-standards/blob/master/manual/php.md
Testing Instructions
Code review
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_joomlaupdate Unit Tests |
Restarted travis as requested
thanks
@marcochirienti we need to take out the changes in administrator/components/com_joomlaupdate/restore.php file as this is 3rd Party code other changes looks good from here.
Ok, i'm sorry, but i'm new to this world. Should i remove changes to this file and send a new pull request?
see here: marcochirienti#1
| Category | Administration com_joomlaupdate Unit Tests | ⇒ | Unit Tests |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13010.
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13010.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13010.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13010.
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-25 18:48:28 |
| Closed_By | ⇒ | zero-24 |
Thanks merged
this is fine by code review
there is no travis error here, anyone can restart travis in this PR?