Feeling Lucky
?
[#13003] - Fixing sql server query foreach error on no database join
- Fixed in Code Base
- 6 Dec 2016
- Medium
- Build: staging
- # 13003
- Diff
- sweco-semhul:sql_server_search_query_warning
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #13002.
Summary of Changes
Adding check to make sure $this->join is set.
Testing Instructions
Setup Joomla against SQL Server, update search index and make a search
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | MS SQL Libraries |
andrepereiradasilva
- comment
- 26 Nov 2016
I have tested this item
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13003.
jeckodevelopment
- comment
- 26 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13003.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 26 Nov 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13003.
zero-24
- | Milestone |
Added: |
||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-06 22:25:11 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on c665361
on code review
good catch
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/13003.