Feeling Lucky
?
[#12986] - [mod-menu] code style changes
- Fixed in Code Base
- 23 Nov 2016
- Medium
- Build: staging
- # 12986
- Diff
- shur:patch-1
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
Code style changes for mod_menu layout.
Testing Instructions
Code review
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Modules Front End |
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-23 10:54:08 |
| Closed_By | ⇒ | Bakual |
| Milestone |
Added: |
||
shur
- comment
- 23 Nov 2016
what you think about if this code:
$id = '';
if ($tagId = $params->get('tag_id', ''))
{
$id = ' id="' . $tagId . '"';
}
replace to:
$id = $params->get('tag_id', '');
$id = $id ? ' id="' . $id . '"' : '';
Bakual
- comment
- 23 Nov 2016
I'd leave the current one as it is more readable (imho).
Looks OK on review here.