Feeling Lucky
?
[#12970] - [com_contact] review config global default options
- Fixed in Code Base
- 27 Jan 2017
- Medium
- Build: staging
- Easy Test
- # 12970
- Diff
- andrepereiradasilva:patch-29
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
This PR intends to normalize onfig global default options in com_contact.
The method used was:
- Review cs of the com_contact config.xml file - also add missing default values
- Check the current params in installation joomla.sql mysql
- Add missing defaults to install sql
Testing Instructions
- Code review
- Apply patch
- Delete configuration.php
- Install Joomla (no sample)
- Create a contact and check all "Use Global" have the global value.
Documentation Changes Required
None.
Added/changed defaults in the xml
changed:
- history_limit: 10 (was 5 - uniformize with articles)
added:
- presentation_style: sliders (was empty - but sliders was the first choice)
- media: empty
- show_user_custom_fields: -1 (was empty - but was the first choice)
- linka_name, linkb_name, linkc_name, linkd_name, linke_name: empty
- icon_address, icon_email, icon_telephone, icon_mobile, icon_fax, icon_misc: empty
- banned_email, banned_subject, banned_text: empty
- redirect: empty
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_contact SQL Installation Postgresql MS SQL |
| Easy | No | ⇒ | Yes |
andrepereiradasilva
- comment
- 8 Dec 2016
@brianteeman just fixed conflicts, imo no need to retest, if ok, please mark as tested again
shubhamnba2009
- comment
- 3 Jan 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12970.
csthomas
- comment
- 26 Jan 2017
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12970.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 26 Jan 2017
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12970.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-01-27 18:19:03 |
| Closed_By | ⇒ | rdeutz | |
| Labels |
Added:
?
|
||
I have tested this item✅ successfully on 4af5f19
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12970.