Feeling Lucky
?
[#12959] - Only show Versions Button if com_contenthistory is enabled
- Fixed in Code Base
- 6 Dec 2016
- Medium
- Build: staging
- # 12959
- Diff
- andrepereiradasilva:patch-25
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for New Issue.
Summary of Changes
If you disable com_contenthistory in Extensions -> Manage you will still get The "Versions" button when editing an item (eg. article).
This PR removes the button in those cases.
Testing Instructions
- Disable com_contenthistory, "Content History" component in Extensions -> Manage
- EDIT an item, for instance an article check there is a versions button there, click on it ... popup with error
- Apply patch
- No button and no error now.
Note: the same is valid for: user note, newsfeed, category, contact, tag, banner, banner client
Documentation Changes Required
None.
Note
There is a "version note" field too and that should be removed in these cases, but that can only be removed if something like #12518 is merged. so is for another PR
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_banners com_categories com_contact com_content com_newsfeeds com_tags com_users |
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
infograf768
- comment
- 21 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12959.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-06 22:17:45 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
I have tested this item✅ successfully on 030b09f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12959.