Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#12953] - Move methods from JLanguage to JLanguageHelper

? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
21 Nov 2016

Summary of Changes

Move all static methods that does not use JLanguage properties or methods from JLanguage to JLanguageHelper and deprecate the other ones.

  • JLanguage::exists() -> JLanguageHelper::exists()
  • JLanguage::getMetadata() -> JLanguageHelper::getMetadata()
  • JLanguage::getKnownLanguages() -> JLanguageHelper::getKnownLanguages()
  • JLanguage::getLanguagePath() -> JLanguageHelper::getLanguagePath()
  • JLanguage::parseLanguageFiles() -> JLanguageHelper::parseLanguageFiles()
  • JLanguage::parseXMLLanguageFile() -> JLanguageHelper::parseXMLLanguageFile()

Testing Instructions

Mainly code review.
Apply patch - all works fine.

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 21 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 21 Nov 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Nov 2016
Category ⇒ Administration com_languages com_search Front End com_users Installation Libraries Modules Plugins Unit Tests
avatar andrepereiradasilva andrepereiradasilva - change - 21 Nov 2016
Title
…
JLanguage to JLanguageHelper
Move methos from JLanguage to JLanguageHelper
avatar andrepereiradasilva andrepereiradasilva - edited - 21 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 21 Nov 2016
Title
…
JLanguage to JLanguageHelper
Move methos from JLanguage to JLanguageHelper
avatar andrepereiradasilva andrepereiradasilva - change - 21 Nov 2016
Title
…
Move methos from JLanguage to JLanguageHelper
Move methods from JLanguage to JLanguageHelper
Labels Removed: ?
avatar andrepereiradasilva andrepereiradasilva - edited - 21 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 21 Nov 2016
Title
…
Move methos from JLanguage to JLanguageHelper
Move methods from JLanguage to JLanguageHelper
avatar alikon
alikon - comment - 24 Nov 2016

I have tested this item ✅ successfully on 6cbb681

tested for a while did'nt discover any issue

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12953.

avatar alikon alikon - test_item - 24 Nov 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 8 Dec 2016

@alikon just fisxed conflicts after #12783 merge.
IMO you don't need to retest, if ok, please mark as tested ok again

avatar alikon
alikon - comment - 9 Dec 2016

I have tested this item ✅ successfully on c2c6d4f

on code review

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12953.

avatar alikon alikon - test_item - 9 Dec 2016 - Tested successfully
avatar anibalsanchez
anibalsanchez - comment - 1 Jan 2017

I have tested this item ✅ successfully on c2c6d4f

Test OK

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12953.

avatar anibalsanchez anibalsanchez - test_item - 1 Jan 2017 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 2 Jan 2017

@andrepereiradasilva can you please look at the conflicting file?

avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Jan 2017

@jeckodevelopment fixed conflicts

avatar zero-24 zero-24 - change - 3 Jan 2017
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2017-01-03 21:34:46
Closed_By ⇒ zero-24
avatar zero-24 zero-24 - close - 3 Jan 2017
avatar zero-24 zero-24 - merge - 3 Jan 2017
avatar zero-24
zero-24 - comment - 3 Jan 2017

Thanks ?

Add a Comment

Login with GitHub to post a comment