[#12946] - mod_menu new option to show or hide icons
- Closed
- 13 May 2017
- Medium
- Build: staging
- # 12946
- Diff
- RoterNagel:dev-menu-icon
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 3 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
I created a new option in the mod_menu. This option makes it possible to create a menu module without the defined icons from the menu item.
Use case: main menu with icons and split menu in the sidebar without icons.
Testing Instructions
You need
- a joomla installation,
- a menu with at least one menu item with a added icon,
- a module for this particular menu which is visible on the website.
- Go to Extentions > modules,
- Pick your menu module for the above mentioned menu,
- Change settings from "Show Icons" to "no",
- Save.
No icons in the menu module on the website.
optional:
5. Change settings from "Show Icons" to "Yes".
6. Save.
The icons should appear again.
Documentation Changes Required
Maybe. Couldn't find a article about the settings from the module for the menu.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Language & Strings Modules Front End |
This is how I did this before. But I think it is not necessary to use an override when you just don't want the icons.
With an override you have to check for changes with a new joomla version. You don't get new features with an override.
without the override system we end up with a million options for everything even if they are rarely used use cases. This is what we should be really trying hard to avoid as it makes the UI very complicated for users.
for me this is a power user feature ideally suited for overrides not for another option that is meaningless to the majority.
Anyway that is my personal opinion
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12946.
I have tested this item
Works as described.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12946.
I have tested this item
Good testet at #JC17de
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12946.
zero-24
- | Status | Pending | ⇒ | Needs Review |
| Labels | |||
This PR is currently in "Needs review" status.
Please @joomla/cms-maintainers
You can do it with the current system so adding an option for this use case seems to my not a great idea. Closing this PR
| Status | Needs Review | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-05-13 21:51:17 |
| Closed_By | ⇒ | rdeutz | |
| Labels | |||
My personal gut feeling on this is that this should be a template override and not another option