? Failure

User tests: Successful: Unsuccessful:

avatar schnuti
schnuti
19 Nov 2016

Pull Request for Issue # .

Summary of Changes

Use of JLayout to enable output overrides.
The rest of the code probably has to stay in JHtml_('calendar') of B/C reasons and wait for J4.

Testing Instructions

  1. Edit/create an item with calendar fields (e.g. article). Check the behaviour of those fields, tooltips and pop-up. (backend and frontend)
  2. Install the patch.
  3. Repeat 1. Nothing should have changed! Advanced test - overrides.
  4. Add a modified calendar.php file to the possible override folders. e.g. your_template/html/layouts/joomla/form/field
  5. Check that the calendar fields are overridden.
avatar schnuti schnuti - open - 19 Nov 2016
avatar schnuti schnuti - change - 19 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 19 Nov 2016
Category Layout Libraries
avatar dgt41
dgt41 - comment - 19 Nov 2016

@schnuti this is already done here: #11138

avatar schnuti
schnuti - comment - 19 Nov 2016

@dgt41 OK, didn't check that.
Wait for 3.7 then? If that's not the next release this smaller fix could maybe be merged? The list of fields with JLayout is growing but calendar is missing as I wanted to use it.
Otherwise I'll close this.

avatar brianteeman
brianteeman - comment - 19 Nov 2016

3.7 is the next scheduled release

On 19 November 2016 at 12:35, Ove Eriksson notifications@github.com wrote:

@dgt41 https://github.com/dgt41 OK, didn't check that.
Wait for 3.7 then? If that's not the next release this smaller fix could
maybe be merged? The list of fields with JLayout is growing but calendar is
missing as I wanted to use it.
Otherwise I'll close this.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12942 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8R2d9YOBgFYa_-fqKZKd68MVzUOKks5q_u0CgaJpZM4K3PTU
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar schnuti
schnuti - comment - 19 Nov 2016

OK! I close this and set for 3.7
I'll try to test the new calendar when it's without known problems.

avatar schnuti schnuti - change - 19 Nov 2016
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2016-11-19 15:33:21
Closed_By schnuti
avatar schnuti schnuti - close - 19 Nov 2016

Add a Comment

Login with GitHub to post a comment