Feeling Lucky
?
?
[#12921] - Catching a throw from JLanguage::parseXMLLanguageFile
- Closed
- 4 Dec 2016
- Medium
- Build: staging
- # 12921
- Diff
- Bakual:DoNotExplodeOnCorruptLanguage
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
If you have a missing language manifest file (eg you deleted it accidentally), you will not be able to login to backend anymore because it will show you a big nice error.
Summary of Changes
Catching the Exception from JLanguage::parseXMLLanguageFile in JLanguageHelper:.getInstalledLanguages and show a useful warning instead.
Testing Instructions
- Install a second language
- Delete the language folders. Don't uninstall the language using the Extension Manager.
- Try editing your profile or log out from backend and try log in again.
With current staging, this will get you a big error and you can't do anything anymore.
With this patch you will get a warning "Could not parse language ArabicUnitag (ar-AA)" which should be more helpful and lets you proceed.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Libraries |
Bakual
- comment
- 17 Nov 2016
Ah, didn't see the other. Having a look.
brianteeman
- comment
- 4 Dec 2016
@bakual can this be closes then?
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12921.
zero-24
- | Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-04 17:47:31 |
| Closed_By | ⇒ | zero-24 |
Already a PR for this #12783 - just needs another test