Feeling Lucky
?
[#12918] - [com_content] Add some missing useglobal
- Fixed in Code Base
- 5 Feb 2017
- Medium
- Build: staging
- # 12918
- Diff
- andrepereiradasilva:patch-21
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
Adds some missing useglobal in com_content and removes two hardcoded default="0" values
Testing Instructions
Mainly code review.
But the chnages are:
- In Articles > List All Categories menu type: blog entries numbers and created date
- In Articles > Category List menu type: created date and removed some hardcoded default values in vote options (Show Votes, Show Ratings)
Documentation Changes Required
None.
@Bakual please check
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
franz-wohlkoenig
- comment
- 5 Feb 2017
I have tested this item
Test on Backend.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12918.
zero-24
- | Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-05 22:24:07 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
I have tested this item✅ successfully on e4c6532
The changes enable for local undefined variables with now added useglobal="true" option to be gathered from the com_content global configuration.
The code does just add the some option useglobal="true" to some properties fields and changes some texs refernces to upper case.
This leads to standard handling of this option for the changed properties.
I checked that every field variable in default.xml with added useglobal="true" option had a matching field in com_content / config.xml
useglobal="true"
I did not check any behaviour in backend or site
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12918.