? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
16 Nov 2016

Summary of Changes

This adds useglobal to com_finder also.

Notes:

  • There are some fields with use global that i don't know where use global is really fetched from (if from somewhere at all ...). Those i didn't touch, because i couldn't get the value.
  • Also removed all hardcoded default values in the ones that useglobal and also removed the options validation
  • Add to removed the integer filter on a field or it would always save with 0

Testing Instructions

  1. Apply patch
  2. Go to com_finder options and save them
  3. Create a menu item of "Smart Search" > "Search" type and check if the use global are correctly populated.

image

image

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 16 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 16 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 16 Nov 2016
Category Front End com_finder
avatar andrepereiradasilva andrepereiradasilva - change - 16 Nov 2016
The description was changed
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - edited - 16 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 16 Nov 2016
Title
[com_finder] Add useglobal to Search menu item type
[com_finder] Add useglobal to "Search" menu item type
avatar andrepereiradasilva andrepereiradasilva - edited - 16 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 16 Nov 2016
Title
[com_finder] Add useglobal to Search menu item type
[com_finder] Add useglobal to "Search" menu item type
avatar brianteeman
brianteeman - comment - 16 Nov 2016

NOTE this is one of the components that does not have all the params pre-populated in the database on install.
If you see some fields that do not show the global value go to the component options and save them again and retest


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12916.

avatar brianteeman brianteeman - test_item - 18 Nov 2016 - Tested successfully
avatar brianteeman
brianteeman - comment - 18 Nov 2016

I have tested this item successfully on 6c6ac0f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12916.

avatar jeckodevelopment
jeckodevelopment - comment - 19 Nov 2016

I have tested this item successfully on 6c6ac0f


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12916.

avatar jeckodevelopment jeckodevelopment - test_item - 19 Nov 2016 - Tested successfully
avatar zero-24 zero-24 - change - 21 Nov 2016
Milestone Added:
Status Pending Ready to Commit
Labels Added: ?
avatar zero-24 zero-24 - change - 21 Nov 2016
Milestone Added:
avatar zero-24 zero-24 - change - 21 Nov 2016
Labels
avatar rdeutz rdeutz - reference | fd1af5d - 6 Dec 16
avatar rdeutz rdeutz - merge - 6 Dec 2016
avatar rdeutz rdeutz - close - 6 Dec 2016
avatar rdeutz rdeutz - change - 6 Dec 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-06 22:15:25
Closed_By rdeutz
avatar rdeutz rdeutz - close - 6 Dec 2016
avatar rdeutz rdeutz - merge - 6 Dec 2016

Add a Comment

Login with GitHub to post a comment