[#12911] - Add useglobal to com_menus Page Display text fields options
- Fixed in Code Base
- 6 Dec 2016
- Medium
- Build: staging
- # 12911
- Diff
- andrepereiradasilva:patch-11
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
For the sake of consistency this adds the new Use Global text to com_menus "Page Display" options.
Testing Instructions
Very simple test:
-
Configure com_menus options like this and save the options
-
Now create a new menu item and go directly to "Page Display" tab
You will see the only one showing the global value is the select list -
Apply patch and repeat last step you will get something like this:
Documentation Changes Required
None.
@Bakual please check if ok.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_menus |
| Title |
|
||||||
| Labels |
Added:
?
|
||||||
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12911.
Technically, this looks good. But I have the same question as @brianteeman - looks quite pointless to me to have global values for those fields.
now checking this better, what is interresting is that the global component value doesn't seem to be inhrited ...
This seems to be done here for show_page_heading, but doens't seem to work for the other params ...
https://github.com/joomla/joomla-cms/blob/staging/libraries/cms/application/site.php#L346
So, something is not quite right here ...
Personally I would just remove the options (if we can, which if they don't
work we can do )
There is some additional processsing of those settings in the views (eg https://github.com/joomla/joomla-cms/blob/staging/components/com_content/views/article/view.html.php#L191).
zero-24
- | Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
| Labels | |||
| Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-06 22:15:04 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 0c614b1
It works
(but i still dont see the point of this field - who is ever going to set an identical browser title or page heading)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12911.