[#12908] - JFormFieldUser now shows stored user ID if user is not found
- Fixed in Code Base
- 6 Dec 2016
- Medium
- Build: staging
- # 12908
- Diff
- Bakual:ShowValueIfNoUserFound
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12881 .
Summary of Changes
JFormFieldUser will now show the User ID instead of the User Name when the user wasn't found in the system.
Testing Instructions
- Create an article (or any other item) and afterwards delete the user who created the article
- Open article, you get a warning message that the user wasn't found. The "Created By" field is empty.
After PR the "Created By" field shows the stored User ID.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
Testers please test other fields such as modified by
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12908.
Found a small issue with the modified by field.
When the articles was only created but never modified afterwards, it should show "Select a User" (at least that's current behavior) and not "0".
Last commit fixes that.
@bakual we have two PR currently (different approaches to the same thing)
to remove the message Select a User which is wrong as you cant - its read
only
On 16 November 2016 at 12:18, Thomas Hunziker notifications@github.com
wrote:
Found a small issue with the modified by field.
When the articles was only created but never modified afterwards, it
should show "Select a User" (at least that's current behavior) and not "0".
Last commit fixes that.—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#12908 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8fcOvtMR18YgQB6v6AzQ99XSjZodks5q-vSQgaJpZM4Kzt5M
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
Ah, wasn't aware of them. Good to know so I don't have to deal with that myself
I have tested this item
Fields now show id of deleted user.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12908.
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12908.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12908.
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-06 22:14:05 |
| Closed_By | ⇒ | rdeutz |
yep
I have tested this item✅ successfully on 3aba301
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12908.