Feeling Lucky
?
[#12905] - [4.0] Fix login
- Fixed in Code Base
- 16 Nov 2016
- Medium
- Build: 4.0-dev
- # 12905
- Diff
- phproberto:j4-authentication
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Summary of Changes
When you try to login in J4 branch you get an error like:
Caused by JAuthentication passing $this to initialise plugins. This gets the dispatcher from JFactory.
Issue was referenced in #12897
Testing Instructions
Apply the patch and confirm that you can login in frontend & backend without errors.
Documentation Changes Required
No changes required
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
phproberto
- comment
- 15 Nov 2016
phproberto
- comment
- 16 Nov 2016
It works here. Not sure if this has further implications though.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-16 13:43:20 |
| Closed_By | ⇒ | mbabker |
zero-24
-
Note to self - go through the last merge again. We lost changes in this class, see https://github.com/joomla/joomla-cms/blob/a416bcc2b237866b66738e5ac14eea067a3f6c87/libraries/joomla/user/authentication.php which was a few weeks ago compared to now.