Feeling Lucky
?
?
[#12899] - [com_fields] Removing deprecated methods and add missing language key
- Fixed in Code Base
- 16 Nov 2016
- Medium
- Build: staging
- # 12899
- Diff
- Bakual:DontUseDeprecatedClass
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
While doing some code reading of com_fields, I stumbled over some deprecated classes, a missing language string and a minor codestyle issue.
Summary of Changes
- Replace
JRuleswithJAccessRules - Replace
JApplication::stringURLSafe()withJApplicationHelper::stringURLSafe() - Replace
JStringwithJoomla\String\StringHelper - Added language key
COM_FIELDS_MUSTCONTAIN_A_TITLE_FIELD - Added a missing
@in a@sincedocbloc
Testing Instructions
Make sure custom fields save.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields Language & Strings |
| Title |
|
||||||
| Labels |
Added:
?
?
|
||||||
| Title |
|
||||||
andrepereiradasilva
- comment
- 16 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12899.
| Status | Pending | ⇒ | Ready to Commit |
dgt41
- comment
- 16 Nov 2016
RTC
zero-24
- | Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-16 19:29:31 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on b1a2c27
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12899.