? Success

User tests: Successful: Unsuccessful:

avatar infograf768
infograf768
13 Nov 2016

Pull Request for Issue #12715

Summary of Changes

Added overrides to boostrap css in the installation template.css in order to use only a highlight color when a button has been selected.

Testing Instructions

Install a clean Joomla as default Multilingual site.
In the specific page to set Multilingual you now should get:
screen shot 2016-11-13 at 15 17 32

@brianteeman
@andrepereiradasilva
@C-Lodder

avatar infograf768 infograf768 - open - 13 Nov 2016
avatar infograf768 infograf768 - change - 13 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 13 Nov 2016
Category Installation
avatar ggppdk
ggppdk - comment - 13 Nov 2016

About cursor showing inside the button

we need to disallow selection on both the group and the button

.btn-group,
.btn {
    -webkit-user-select: none;
    -moz-user-select: none;
    -ms-user-select: none;
    user-select: none;
}

About active color on buttons, it looks too exposed, and makes words yes / no harder to read
-- maybe a little darker flavour: #5a97d7

avatar infograf768
infograf768 - comment - 13 Nov 2016

cursor showing ?

avatar ggppdk
ggppdk - comment - 13 Nov 2016

yes it does , cursor is not showing "inside" the buttons,
the cursor is shown inside the fieldset button group, and it appears as it is inside the second button (but it is actually inside the button group)

e.g. in firefox click besides the buttons, or on the 2nd button

avatar infograf768
infograf768 - comment - 13 Nov 2016

is that due to this patch?

avatar ggppdk
ggppdk - comment - 13 Nov 2016

is that due to this patch?

no

avatar infograf768
infograf768 - comment - 14 Nov 2016

Let's leave this as it is unrelated.
Modified colour to the deeper shade of blue you proposed.

screen shot 2016-11-14 at 08 59 31

avatar brianteeman
brianteeman - comment - 14 Nov 2016

Colour is great - thanks

I am not a css expert but I am pretty sure that the css can be written in shorthand instead of all those classes being specified directly. @C-Lodder @ciar4n am I correct or talking the usual rubbish

avatar C-Lodder
C-Lodder - comment - 14 Nov 2016

This wouldn't pass WCAG AA, so would suggest making the blue a little darker (#386cac).

#294f7e if you want it to pass AAA

avatar brianteeman
brianteeman - comment - 14 Nov 2016

#294f7e looks good to me

avatar ciar4n
ciar4n - comment - 14 Nov 2016

I haven't test this but you could shorten it to something like the following presuming the pseudo class colors are inherited (add !important if not)...

#jform_activateMultilanguage [class^="btn-"],
#jform_installLocalisedContent [class^="btn-"],
#jform_activatePluginLanguageCode [class^="btn-"] {
    background-color: #5a97d7;
    color: #fff;
}
avatar C-Lodder
C-Lodder - comment - 14 Nov 2016

@ciar4n , need to target the active state:

#jform_activateMultilanguage [class^="btn-"]:active,
#jform_activateMultilanguage [class^="btn-"].active,
#jform_installLocalisedContent [class^="btn-"]:active,
#jform_installLocalisedContent [class^="btn-"].active,
#jform_activatePluginLanguageCode [class^="btn-"]:active,
#jform_activatePluginLanguageCode [class^="btn-"].active {
    background-color: #294f7e;
}

Note: color: #fff; is already set, so no need to redefine it.

avatar brianteeman
brianteeman - comment - 14 Nov 2016

Thanks guys

avatar infograf768
infograf768 - comment - 14 Nov 2016

I evidently accept any PR towards my branch. ?

avatar C-Lodder
C-Lodder - comment - 14 Nov 2016

@infograf768 - ^ doesn't seem to work in FF for me, so used * instead:

infograf768#45

avatar infograf768
infograf768 - comment - 14 Nov 2016

will test after siesta ?

avatar brianteeman
brianteeman - comment - 14 Nov 2016

Please update when you have merged so I can test it - thanks


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12879.

avatar infograf768
infograf768 - comment - 15 Nov 2016

Merged infograf768#45

We now get:

screen shot 2016-11-15 at 06 52 02

avatar brianteeman
brianteeman - comment - 15 Nov 2016

I have tested this item successfully on bf0fae9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12879.

avatar brianteeman brianteeman - test_item - 15 Nov 2016 - Tested successfully
avatar C-Lodder C-Lodder - test_item - 15 Nov 2016 - Tested successfully
avatar C-Lodder
C-Lodder - comment - 15 Nov 2016

I have tested this item successfully on bf0fae9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12879.

avatar ggppdk
ggppdk - comment - 15 Nov 2016

I have tested this item successfully on bf0fae9


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12879.

avatar ggppdk ggppdk - test_item - 15 Nov 2016 - Tested successfully
avatar brianteeman brianteeman - change - 15 Nov 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 15 Nov 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12879.

avatar zero-24 zero-24 - change - 15 Nov 2016
Milestone Added:
avatar dgt41
dgt41 - comment - 15 Nov 2016

Why inconsistent colours here?

avatar C-Lodder
C-Lodder - comment - 15 Nov 2016

You can use the same colour as the "Next" button above. This is level AA compliant. Choice is up to you guys

avatar infograf768
infograf768 - comment - 15 Nov 2016

Folks, just make up your mind... It is easy to change...

avatar mbabker
mbabker - comment - 15 Nov 2016

I think it's fine as is. Visually I'd somewhat expect the buttons to have a different shade from form inputs.

avatar wilsonge wilsonge - close - 15 Nov 2016
avatar wilsonge wilsonge - merge - 15 Nov 2016
avatar wilsonge wilsonge - reference | 3ac49e0 - 15 Nov 16
avatar wilsonge wilsonge - merge - 15 Nov 2016
avatar wilsonge wilsonge - change - 15 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-15 20:46:13
Closed_By wilsonge
avatar wilsonge wilsonge - close - 15 Nov 2016

Add a Comment

Login with GitHub to post a comment