[#12871] - First Level Menu item alias: preventing saving forbidden aliases
- Fixed in Code Base
- 15 Nov 2016
- Medium
- Build: staging
- # 12871
- Diff
- infograf768:menu_item_alias
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12862
In joomla, a first level menu item alias should not be the name of a folder.
Also, it should not be component
When creating a new menu item at the ROOT of the Menu and NOT filling the alias field, that one is automatically created (same when the menu item is not at the ROOT, but in this case we do not have the issue).
This is done in the store() method and therefore the forbidden aliases are not yet checked by the check() method.
Summary of Changes
Moving the checks for forbidden aliases from the check() method to the store() method
Testing Instructions
Create a new menu item (for example a single article one) at the ROOT of the Menu.
Give it the Title of a folder in the root of the site, for example tmp.
Do NOT fill the alias field.
The menu item is saved with tmp as alias.
Do the same, but use component as title.
The menu item is saved with component as alias.
Trash and delete these menu items.
Patch and redo. Now you will rightfully get the message:
Save failed with the following error: A first level menu item alias can't be 'tmp' because 'tmp' is a sub-folder of your joomla installation folder.
and similar message when using component
Save failed with the following error: A first level menu item alias can't be 'component'.
and the menu item is not saved.
Editing a ROOT existing menu item and changing its alias to a folder name or component will still be prevented from save.
Votes
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
I have tested this item
after applying pathc
Save failed with the following error: A first level menu item alias can't be 'tmp' because 'tmp' is a sub-folder of your joomla installation folder.
message appear
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12871.
| Status | Pending | ⇒ | Ready to Commit |
RTC. Thanks for testing!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12871.
zero-24
- | Milestone |
Added: |
||
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-15 21:50:43 |
| Closed_By | ⇒ | rdeutz |
Followed the instruction and successfully tested the issue. confriming the patch worked fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12871.