? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
11 Nov 2016

This PR expands the already merged #11911 to com_contact

Summary of Changes

Enables the new "Show Global Value" feature for all contact forms.

Testing Instructions

Test the contact form and the related menu item forms. All list elements with a "Use Global" entry should show the global value like this:
showglobal

Exception: The robots field will not show the global value.

Note: If you get a message that some global values can't be found, try saving the component options.

Documentation Changes Required

None

avatar Bakual Bakual - open - 11 Nov 2016
avatar Bakual Bakual - change - 11 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2016
Category Administration Components Front End
avatar Bakual
Bakual - comment - 11 Nov 2016

On a sidenote I fixed the "Filter Field" parameter in the categories menu item type. Currently it doesn't allow to hide the filter field, after this PR it will allow it.
See https://github.com/joomla/joomla-cms/pull/12861/files#diff-c732953186c3675745659a96049747f7L172 for the fix which is a simple and obvious one.

avatar zero-24
zero-24 - comment - 11 Nov 2016

@yvesh what is broke here with drone here? I have just tryed to reboot it.

avatar zero-24
zero-24 - comment - 11 Nov 2016

Ok works now @yvesh . Thanks

avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Nov 2016

seems some are missing

image

image

avatar Bakual
Bakual - comment - 11 Nov 2016

Missed the "redirect" and "link" fields.
The "banned" fields are textares which don't support that feature. Same for the "show user custom fields" field. We would have to add that feature first there.

avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Nov 2016

@Bakual while you are making that change can you change the order of the "Show"/"Hide" of "Contact Information" option? It's just in the opposite order of all the other ones.

avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2016
Category Administration Components Front End Administration com_contact Front End Components
avatar Bakual
Bakual - comment - 11 Nov 2016

Fixed that order so it's consistent.

avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Nov 2016

I have tested this item successfully on d8e13f8

works as described


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12861.

avatar andrepereiradasilva andrepereiradasilva - test_item - 11 Nov 2016 - Tested successfully
avatar alikon alikon - test_item - 13 Nov 2016 - Tested successfully
avatar alikon
alikon - comment - 13 Nov 2016

I have tested this item successfully on d8e13f8


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12861.

avatar brianteeman brianteeman - change - 13 Nov 2016
Status Pending Ready to Commit
avatar brianteeman
brianteeman - comment - 13 Nov 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12861.

avatar brianteeman brianteeman - change - 13 Nov 2016
Milestone Added:
avatar brianteeman brianteeman - change - 13 Nov 2016
Labels Added: ?
avatar rdeutz rdeutz - reference | cec7a97 - 15 Nov 16
avatar rdeutz rdeutz - merge - 15 Nov 2016
avatar rdeutz rdeutz - close - 15 Nov 2016
avatar rdeutz rdeutz - close - 15 Nov 2016
avatar rdeutz rdeutz - merge - 15 Nov 2016
avatar rdeutz rdeutz - change - 15 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-15 21:48:23
Closed_By rdeutz
avatar Bakual Bakual - head_ref_deleted - 15 Nov 2016

Add a Comment

Login with GitHub to post a comment