[#12858] - Removing the notice when a global value is not found.
- Fixed in Code Base
- 13 Nov 2016
- Medium
- Build: staging
- # 12858
- Diff
- Bakual:RemoveMissingGlobalMessage
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12782.
Summary of Changes
Removing the notice when the global value isn't found (not yet saved) as it is more confusing to users than it helps.
Testing Instructions
On a new install, create a menu item for com_content or edit an article.
You should see a notice that no global value was found. Reason is that either component settings, com_menu settings or global settings aren't saved yet.
After PR this message no longer appears.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Language & Strings Libraries |
| Milestone |
Added: |
||
unable to mark as tested because of "sha thing"
But, works as described.
Althoug i think that we should use something like "Use Global (Unable to calculate)" or something
I realize this and I still have no idea what is causing it because everything that I have traced shows it being correctly sent/set. I don't need to be @ mentioned every time.
I'm also only one person, the code is open source, anyone's welcome to help try to figure out the issue (hint, it's not the controller processing that save action, it's something saving the data somewhere in the tracker component ("app")).
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12858.
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
It should not sound agressive jut to inform you. If you don't need that i'm ok with that
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12858.
Believe it or not I read almost every email notification I get for this repo, so I see most of the activity (and the failures). The thing is though it gets kinda annoying when I get "@mbabker it's broken" messages consistently, all it takes is a simple comment or opening an issue on the issue tracker's tracker and I can jump into it when I get a moment. About the only thing I don't have is email notifications from the tracker app itself on a fail condition.
I think the SHA thing is fine now. The issue model's save method was accidentally coded to remove a few fields if they weren't passed in with the save data (fixed that an hour ago). We'll see what happens. I really wish I would've followed through on rewriting the thing and getting it into a testable state.
Thank you for your time on this Michael
roland-d
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-13 06:21:28 |
| Closed_By | ⇒ | roland-d |
I have tested this item✅ successfully on a917fc2
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12858.