? Success

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
10 Nov 2016

Pull Request for Issue #12843 .

Summary of Changes

The PRs to create a category "on the fly" (#8623, #8635, #8634, #8632, #8433) changed the call to load Chosen so the search field shows always. By default it would only show if there are more than 10 options.
This PR reverts that change and adds a specific Chosen call for the category field only.

Testing Instructions

Test the following backend edit forms

  • Article
  • Banner
  • Newsfeed
  • Contact
  • Custom Field
  • Module (Position field)

Before PR each list field shows a search field:
state

After PR the searchfield is gone except for the category (fields group) field.
category

Documentation Changes Required

None

avatar Bakual Bakual - open - 10 Nov 2016
avatar Bakual Bakual - change - 10 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 10 Nov 2016
Category Administration Components
avatar smehrbrodt
smehrbrodt - comment - 10 Nov 2016

Hm the search might be useful if you have many languages, or many access levels.

avatar Bakual
Bakual - comment - 10 Nov 2016

Hm the search might be useful if you have many languages, or many access levels.

Indeed.
Maybe "removing" was the wrong word used in the PR. I've set it back to default.
By default it will show when you have 10 and more items in the list. So if you have many languages or access levels, you will get the search box automatically.

avatar dgt41 dgt41 - test_item - 10 Nov 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 10 Nov 2016

I have tested this item successfully on 1907a6a


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12855.

avatar brianteeman
brianteeman - comment - 11 Nov 2016

I can see why to remove it on status but I would keep it on category


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12855.

avatar Bakual
Bakual - comment - 11 Nov 2016

I can see why to remove it on status but I would keep it on category

Is it gone on category? See testing instructions:

After PR the searchfield is gone except for the category (fields group) field.

It should stay for the category. It should only be gone for all other fields with less than 10 items.

avatar brianteeman
brianteeman - comment - 11 Nov 2016

Shoot - misread the instructions

avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Nov 2016

tested all forms with permissions tabs in the core.
we still have the search box in new/edit module permissions tab.

avatar Bakual
Bakual - comment - 12 Nov 2016

we still have the search box in new/edit module permissions tab.

Looks like I missed one then. I'll add that one later today. ?

avatar Bakual Bakual - edited - 12 Nov 2016
avatar joomla-cms-bot joomla-cms-bot - change - 12 Nov 2016
Category Administration Components Administration com_banners com_contact com_content com_fields com_modules com_newsfeeds Components
avatar Bakual
Bakual - comment - 12 Nov 2016

Fixed in the module edit view as well and updated test instructions.

avatar andrepereiradasilva andrepereiradasilva - test_item - 12 Nov 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 12 Nov 2016

I have tested this item successfully on 6090afe

works as described


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12855.

avatar infograf768 infograf768 - test_item - 13 Nov 2016 - Tested successfully
avatar infograf768
infograf768 - comment - 13 Nov 2016

I have tested this item successfully on 6090afe


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12855.

avatar infograf768 infograf768 - change - 13 Nov 2016
Status Pending Ready to Commit
avatar infograf768
infograf768 - comment - 13 Nov 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12855.

avatar brianteeman brianteeman - change - 15 Nov 2016
Milestone Added:
avatar rdeutz rdeutz - reference | 3a83ce8 - 15 Nov 16
avatar rdeutz rdeutz - merge - 15 Nov 2016
avatar rdeutz rdeutz - close - 15 Nov 2016
avatar rdeutz rdeutz - change - 15 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-15 21:47:21
Closed_By rdeutz
avatar rdeutz rdeutz - close - 15 Nov 2016
avatar rdeutz rdeutz - merge - 15 Nov 2016
avatar Bakual Bakual - head_ref_deleted - 15 Nov 2016

Add a Comment

Login with GitHub to post a comment