? ? Success

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
9 Nov 2016

Summary of Changes

Small PR

All items that allow permissions across the core: Articles, Menu, Fields (Articles, Contacts and Users) and Categories (Articles, Banners, Contacts, News Feeds and Field Groups in Articles, Contacts and Users) and all component Options have the last tab named "Permissions".

There is only two different: Modules and Global config, in case of the modules the tab is even called "Module Permissions" ...

image

image

So, this PR makes modules and global config behave like all the others views in this matter, ie, always the last tab and always with "Permissions" name.

Testing Instructions

Very simple test. (30 sec)

  • Apply patch
  • Go to global config and check the last tab is "Permissions"
  • Create/Edit a module and check the last tab is "Permissions"

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 9 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 9 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Nov 2016
Category Administration Components Language & Strings
avatar brianteeman
brianteeman - comment - 9 Nov 2016

Shouldnt you change this as well?

screen shot 2016-11-09 at 13 02 07


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12851.

avatar andrepereiradasilva
andrepereiradasilva - comment - 9 Nov 2016

oh didmn't notice that one. yes i will change.

avatar andrepereiradasilva
andrepereiradasilva - comment - 9 Nov 2016

done

avatar ggppdk
ggppdk - comment - 9 Nov 2016

I have tested this item successfully on a85cbb0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12851.

avatar ggppdk ggppdk - test_item - 9 Nov 2016 - Tested successfully
avatar jeckodevelopment jeckodevelopment - test_item - 9 Nov 2016 - Tested successfully
avatar jeckodevelopment
jeckodevelopment - comment - 9 Nov 2016

I have tested this item successfully on a85cbb0


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12851.

avatar jeckodevelopment jeckodevelopment - change - 9 Nov 2016
Status Pending Ready to Commit
avatar jeckodevelopment
jeckodevelopment - comment - 9 Nov 2016

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12851.

avatar jeckodevelopment jeckodevelopment - change - 9 Nov 2016
Milestone Added:
avatar jeckodevelopment
jeckodevelopment - comment - 9 Nov 2016

RTC
Hey bot! ?


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12851.

avatar zero-24
zero-24 - comment - 9 Nov 2016

You calling me :p @jeckodevelopment what is wrong ;)

avatar rdeutz rdeutz - change - 10 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-10 09:02:56
Closed_By rdeutz
avatar rdeutz rdeutz - close - 10 Nov 2016
avatar rdeutz rdeutz - merge - 10 Nov 2016
avatar rdeutz rdeutz - reference | 12d0f7a - 10 Nov 16
avatar rdeutz rdeutz - merge - 10 Nov 2016
avatar rdeutz rdeutz - close - 10 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - head_ref_deleted - 10 Nov 2016

Add a Comment

Login with GitHub to post a comment