[#12821] - [ACL] [new/edit category] Remove categoryedit field check of - No parent - option
- Fixed in Code Base
- 5 Feb 2017
- Medium
- Build: staging
- # 12821
- Diff
- andrepereiradasilva:patch-32
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Failure continuous-integration/appveyor/pr AppVeyor build failed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
The categoryedit field (which actually is the category parent select box) is making an ACL check to the "- No parent -" option to decide whether to show the field or not.
This doesn't make much sense. This PR correct that.
Note: it will also be a bit faster since now the ACL check is the last of the condition.
Testing Instructions
Mainbly code review, but you can also:
- Apply patch
- Check category edit field work as usual
Documentation Changes Required
none.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration Components |
| Labels |
Added:
?
|
||
| Category | Administration Components | ⇒ | Administration com_categories Components |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12821.
Article View is broken
I have tested this item
View is broken, logged in / out, cache is cleared
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12821.
confirmed broken view: Fatal error: Class 'JFormAbstractlist' not found in /administrator/components/com_categories/models/fields/categoryedit.php on line 19
@andrepereiradasilva @franz-wohlkoenig @coolcat-creations i have just merged staging is that should fix the issue you reported can you double check that?
I have tested this item
Tested successfully, also ACL still works for those that are not allowed to create.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12821.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
?
|
||
RTC as the issue was just a not synced branche wich is fixed now. Thanks!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12821.
I have tested this item
"New", "Edit" a Article-Category works without Issue.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12821.
Thanks both for retesting
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-02-05 22:36:43 |
| Closed_By | ⇒ | wilsonge | |
| Labels | |||
I have tested this item✅ successfully on dfb3f53
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12821.