? Success

User tests: Successful: Unsuccessful:

avatar laoneo
laoneo
7 Nov 2016

Pull Request for PR #12740.

Summary of Changes

Reverts the type of default value back to textarea. Editors can have multiline default values or special lists can have newlines as separator. We will be on the safe side when we go with textarea.

Testing Instructions

Check if the default value field is a text area.

avatar laoneo laoneo - open - 7 Nov 2016
avatar laoneo laoneo - change - 7 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 7 Nov 2016
Category Administration Components
avatar laoneo laoneo - change - 7 Nov 2016
Title
Change type of default value back to textarea
[com_fields] Change type of default value back to textarea
avatar laoneo laoneo - change - 7 Nov 2016
Title
Change type of default value back to textarea
[com_fields] Change type of default value back to textarea
Labels Added: ?
avatar laoneo laoneo - edited - 7 Nov 2016
avatar brianteeman
brianteeman - comment - 6 Dec 2016

I dont see the reasoning for this change. When preparing a demo of com_fields I found I was using the simple text field more than any other. Surely the default should be the most used.


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12811.

avatar Bakual
Bakual - comment - 6 Dec 2016

@brianteeman It's the field for the default value, not the default field.
default

avatar brianteeman
brianteeman - comment - 6 Dec 2016

Ah - thanks for clarifying

On 6 Dec 2016 4:24 p.m., "Thomas Hunziker" notifications@github.com wrote:

@brianteeman https://github.com/brianteeman It's the field for the
default value, not the default field.
[image: default]
https://cloud.githubusercontent.com/assets/1018684/20933602/debac27c-bbd8-11e6-80a4-967a41b54390.PNG


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12811 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8RUzSQIEqU-uyaQe63IEQ5N-xOtEks5rFYxMgaJpZM4KrL7P
.

avatar joomla-cms-bot joomla-cms-bot - change - 7 Dec 2016
Category Administration Components Administration com_fields Components
avatar brianteeman
brianteeman - comment - 7 Dec 2016

I have tested this item successfully on 8d8ba76


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12811.

avatar brianteeman brianteeman - test_item - 7 Dec 2016 - Tested successfully
avatar alikon
alikon - comment - 7 Dec 2016

I have tested this item successfully on 8d8ba76


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12811.

avatar alikon alikon - test_item - 7 Dec 2016 - Tested successfully
avatar laoneo
laoneo - comment - 7 Dec 2016

Thanks

avatar Bakual Bakual - reference | 463725e - 7 Dec 16
avatar Bakual Bakual - merge - 7 Dec 2016
avatar Bakual Bakual - close - 7 Dec 2016
avatar Bakual Bakual - change - 7 Dec 2016
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-12-07 20:34:20
Closed_By Bakual
avatar Bakual Bakual - close - 7 Dec 2016
avatar Bakual Bakual - merge - 7 Dec 2016
avatar Bakual Bakual - change - 7 Dec 2016
Milestone Added:
avatar laoneo laoneo - head_ref_deleted - 8 Dec 2016

Add a Comment

Login with GitHub to post a comment