Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#12798] - [ACL] [com_newsfeeds newsfeeds view] Correct invalid check

? Pending

User tests: Successful: Unsuccessful:

avatar andrepereiradasilva
andrepereiradasilva
7 Nov 2016

Summary of Changes

There is an ACL check $user->authorise('core.edit.state', 'com_newsfeeds.category') in this view.
This is an invalid ACL check. For ACL check categories we need to check with the category id (example: 'com_newsfeeds.category.99'.)

So this PR removes this ACL check, since it is doing nothing and is bad code.

Testing Instructions

Mainly code review, but you can test if newsfeeds view continues to work.
1. Apply patch
2. Newsfeeds view still work.

Documentation Changes Required

None.

avatar andrepereiradasilva andrepereiradasilva - open - 7 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 7 Nov 2016
Status New ⇒ Pending
avatar andrepereiradasilva andrepereiradasilva - change - 7 Nov 2016
Title
…
[com_newsfeeds newsfeed view] Remove invalid ACL check
[com_newsfeeds newsfeeds view] Remove invalid ACL check
avatar andrepereiradasilva andrepereiradasilva - change - 7 Nov 2016
Title
…
[com_newsfeeds newsfeed view] Remove invalid ACL check
[com_newsfeeds newsfeeds view] Remove invalid ACL check
Labels Added: ?
avatar andrepereiradasilva andrepereiradasilva - edited - 7 Nov 2016
avatar joomla-cms-bot joomla-cms-bot - change - 7 Nov 2016
Category ⇒ Administration Components Templates (admin)
avatar andrepereiradasilva andrepereiradasilva - change - 7 Nov 2016
Title
…
[com_newsfeeds newsfeeds view] Remove invalid ACL check
[ACL] [com_newsfeeds newsfeeds view] Remove invalid check
avatar andrepereiradasilva andrepereiradasilva - change - 7 Nov 2016
Title
…
[com_newsfeeds newsfeeds view] Remove invalid ACL check
[ACL] [com_newsfeeds newsfeeds view] Remove invalid check
avatar andrepereiradasilva andrepereiradasilva - edited - 7 Nov 2016
avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Nov 2016

reverted change as discussed in #12799

now the only change is corrected the asset name from com_newsfeeds.category to com_newsfeeds.

avatar andrepereiradasilva andrepereiradasilva - change - 11 Nov 2016
Title
…
[ACL] [com_newsfeeds newsfeeds view] Remove invalid check
[ACL] [com_newsfeeds newsfeeds view] Correct invalid check
avatar andrepereiradasilva andrepereiradasilva - edited - 11 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 11 Nov 2016
Title
…
[ACL] [com_newsfeeds newsfeeds view] Remove invalid check
[ACL] [com_newsfeeds newsfeeds view] Correct invalid check
avatar andrepereiradasilva
andrepereiradasilva - comment - 11 Nov 2016

closed will be replace by one more integrated PR

avatar andrepereiradasilva andrepereiradasilva - close - 11 Nov 2016
avatar andrepereiradasilva andrepereiradasilva - change - 11 Nov 2016
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-11-11 15:21:27
Closed_By ⇒ andrepereiradasilva
avatar joomla-cms-bot joomla-cms-bot - change - 11 Nov 2016
Category Administration Components Templates (admin) ⇒ Administration com_newsfeeds Templates (admin) Components

Add a Comment

Login with GitHub to post a comment