Feeling Lucky
?
[#12788] - Fix: JToolbarButtonPopup doesn't respect passed width and height
- Closed
- 9 Dec 2016
- Medium
- Build: staging
- # 12788
- Diff
- zero-24:fix_popup
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12747
Summary of Changes
The passed parameters should now be respected by the joomla.modal.main layout.
Testing Instructions
$bar = JToolbar::getInstance('toolbar');
$bar->appendButton('Popup', 'search', \JText::_('JGLOBAL_PREVIEW'), \JRoute::_($previewUrl), 800, 600);Documentation Changes Required
None.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-12-09 15:14:26 |
| Closed_By | ⇒ | zero-24 |
Not sure if I was testing this correctly. I added the sample code to a view.html.php and the button appeared. But both before and after the PR changing the size had no effect
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12788.