? ? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
4 Nov 2016

Summary of Changes

Correct labels in the installation (and their error strings)

Before

joomla web installer - before

After

screen shot 2016-11-05 at 06 50 57

UPDATED SCREESHOTS

avatar brianteeman brianteeman - open - 4 Nov 2016
avatar brianteeman brianteeman - change - 4 Nov 2016
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 4 Nov 2016
Category Installation Language & Strings
avatar zero-24
zero-24 - comment - 5 Nov 2016

Super User Username?

What abaut dropping that (Administrator vs. Super User) completly? But keep it in the description?

avatar ggppdk
ggppdk - comment - 5 Nov 2016

What abaut dropping that (Administrator vs. Super User) completly? But keep it in the description?

It can be done, but best way to avoid repetition

  • is to add a header to the 4 fields:

Super user account

and then maybe remove the descriptions and make them a popup

avatar brianteeman
brianteeman - comment - 5 Nov 2016

The problem is we use the term administrator to mean the joomla back end.
This pr is just addressing that we also mistakenly used it to mean super
user

avatar ggppdk ggppdk - test_item - 5 Nov 2016 - Tested successfully
avatar ggppdk
ggppdk - comment - 5 Nov 2016

I have tested this item successfully on de407d7

(regardless of other extra improvements that can be done, like adding a header to avoid repetition of 'Super User')

This change is correct


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12756.

avatar andrepereiradasilva andrepereiradasilva - test_item - 5 Nov 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Nov 2016

I have tested this item successfully on de407d7

code review


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12756.

avatar brianteeman
brianteeman - comment - 5 Nov 2016

Better like this?

image

avatar brianteeman brianteeman - change - 5 Nov 2016
The description was changed
Labels
avatar brianteeman brianteeman - change - 5 Nov 2016
Labels
avatar brianteeman brianteeman - edited - 5 Nov 2016
avatar brianteeman
brianteeman - comment - 5 Nov 2016

OK I have redone the layout based screenshot above. Thanks guys


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12756.

avatar andrepereiradasilva
andrepereiradasilva - comment - 5 Nov 2016

no sha in issue tracker but tested with success

avatar ggppdk
ggppdk - comment - 5 Nov 2016

I have tested this item successfully on ad7e0dc

Temporarily renamed configuration.php,
so that installation script runs in my local github repositiory without creating a new repository

new header is good,
and new language strings appear for English (United Kingdom)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12756.

avatar ggppdk ggppdk - test_item - 5 Nov 2016 - Tested successfully
avatar dgt41 dgt41 - test_item - 5 Nov 2016 - Tested successfully
avatar dgt41
dgt41 - comment - 5 Nov 2016

I have tested this item successfully on ad7e0dc


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12756.

avatar dgt41 dgt41 - change - 5 Nov 2016
Status Pending Ready to Commit
avatar dgt41
dgt41 - comment - 5 Nov 2016

@brianteeman may I propose one more change?
Add a note field with some text explaining what is a Super User

avatar brianteeman
brianteeman - comment - 5 Nov 2016

I am not sure about that. We dont have anything now.
If we do that then I would prefer it if it was part of a wider review of
the intended purpose of the SU account

On 5 November 2016 at 13:38, Dimitri Grammatikogianni <
notifications@github.com> wrote:

@brianteeman https://github.com/brianteeman may I propose one more
change?
Add a note field with some text explaining what is a Super User


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12756 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8UJTCtai8ofRCIEV_ClKLAaiLhUJks5q7IbdgaJpZM4KqEq6
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar ggppdk
ggppdk - comment - 5 Nov 2016

Add a note field with some text explaining what is a Super User

Exactly, actually explaining what is the super user makes a lot more sense,
than explaining what email / username / password are

And then with the header and the description,
the inline descriptions of email / username / password can be removed !


This description should be enough just after the header:

  • This account is allowed to manage anything in your new website
avatar dgt41
dgt41 - comment - 5 Nov 2016

We dont have anything now.

Which is wrong, these terms (not only Super User) are familiar to Joomla users but might be a totally new term for newcomers...

@ggppdk I totally agree

avatar brianteeman
brianteeman - comment - 5 Nov 2016

Feel free to start your own PR for that. Its out of scope for this one.

As i said i would prefer to completely review every aspect of the SU
account system so I dont believe it is right to introduce the new note at
this time

On 5 November 2016 at 13:50, Dimitri Grammatikogianni <
notifications@github.com> wrote:

We dont have anything now.

Which is wrong, these terms (not only Super User) are familiar to Joomla
users but might be a totally new term for newcomers...

@ggppdk https://github.com/ggppdk I totally agree


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#12756 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8YGKi6Teot3YJoQUCTd-sSk0a4Tpks5q7InBgaJpZM4KqEq6
.

Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/

avatar dgt41
dgt41 - comment - 5 Nov 2016

so I dont believe it is right to introduce the new note at this time

All I am saying is that, for newcomers, we expect (which is a great UX fault) to figure out themselves what a SU is. Don't let people guess, cause there might end up with wrong conclusions, just tell them...

But anyways, if you think we should do it in another PR, let's drop it here and hopefully someone will pick up and do a PR

avatar brianteeman brianteeman - change - 8 Nov 2016
Milestone Added:
avatar rdeutz rdeutz - change - 8 Nov 2016
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2016-11-08 09:00:22
Closed_By rdeutz
avatar rdeutz rdeutz - close - 8 Nov 2016
avatar rdeutz rdeutz - merge - 8 Nov 2016
avatar rdeutz rdeutz - reference | bf65edb - 8 Nov 16
avatar rdeutz rdeutz - merge - 8 Nov 2016
avatar rdeutz rdeutz - close - 8 Nov 2016
avatar brianteeman
brianteeman - comment - 8 Nov 2016

Thanks

avatar brianteeman brianteeman - head_ref_deleted - 8 Nov 2016

Add a Comment

Login with GitHub to post a comment