[#12750] - Fix error notice on front-end search
- Fixed in Code Base
- 4 Nov 2016
- Medium
- Build: staging
- # 12750
- Diff
- roland-d:fix-broken-search-filter
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Summary of Changes
With the merge of #11833 the search filter broke. See here:
https://github.com/joomla/joomla-cms/pull/11833/files#diff-b32bbae639a4113309650b03c2b09ba1L113
The line $wheres[] = implode(' OR ', $wheres2); got removed by accident it looks. This PR adds this line back.
Testing Instructions
- Install Joomla with sample data
- Go to the front-end and search for any word with the search box in the top right corner
- You will see an error notice "An error has occured"
- Apply patch
- Re-run the search query and the error is gone.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
| Milestone |
Added: |
||
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item
- I have installed Joomla with sample data
- I go to the front-end and search for any word with the search box in the top right corner
- I get an error notice "An error has occured"
- I applied patch
- I have re-run the search query and the error is gone.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12750.
| Status | Pending | ⇒ | Ready to Commit |
Setting RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12750.
wonder why that file was changed with the com_fields pr. how is it related to that?
@infograf768 Did you check the code? It adds a filter to the com_fields table.
To make field data searchable? I remember seeing this thread on the other repo but don't remember what it resulted in.
@infograf768 That is another question not related to this PR. Fact remains that the code is broken by removing this specific line.
@roland-d just a heads up here, implode should be executed only on non-empty arrays: #12321 (comment)
I thing this is something that needs to be patched is several models
wilsonge
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-04 16:18:03 |
| Closed_By | ⇒ | wilsonge |
Tested. Search fields value may or may not work depending on field.
For example Text and Timezone work but not list
I have tested this item✅ successfully on e39a438
Patch is working correctly
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12750.