Feeling Lucky
?
[#12748] - JInstallerAdapterTemplate - rewrote hardcoded SQL to object
- Closed
- 10 Sep 2017
- Medium
- Build: staging
- # 12748
- Diff
- pe7er:sql2queryobj
- Success continuous-integration/drone/pr the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success continuous-integration/appveyor/pr AppVeyor build succeeded Details
- Error continuous-integration/jenkins/pr-merge This commit cannot be built Details
User tests: Successful: Unsuccessful:
I've rewrote the hard-coded SQL to $query object in two places.
Note: The second SQL query contained an in() with subquery.
Please triple double check my implementation of that query with the $query object using a $subquery.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
pe7er
- comment
- 5 Feb 2017
Thanks for testing Marc!
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12748.
brianteeman
- comment
- 9 Sep 2017
Can you look at resolving the conflicts so that this can be tested please.
pe7er
- comment
- 10 Sep 2017
My PR was to correct the file /libraries/cms/installer/adapter/template.php but I cannot find it in the current staging anymore...
wojsmol
- comment
- 10 Sep 2017
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2017-09-10 14:09:08 |
| Closed_By | ⇒ | pe7er |
I have tested this item✅ successfully on 655b987
successfuly getestet
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12748.