Feeling Lucky
?
[#12737] - [libraries] Undesired Notices when publishing child category
- Fixed in Code Base
- 4 Nov 2016
- Medium
- Build: staging
- # 12737
- Diff
- infograf768:cat_notices
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12726
Summary of Changes
Making sure not to include in a sprintf an array ($pks is an array, we need the id #)
Making sure the variable is defined
Testing Instructions
Create a Category (for example in articles)
Create a sub category of the former one
Unpublish the parent category.
This will also unpublish the child.
Now try to publish the child category
You will, rightfully get an error:
Error
Failed publishing 1 category as at least one of its parents is unpublished or one of its children is checked out.
But, we also a get 2 Notices in the php logs
[02-Nov-2016 16:24:32 UTC] PHP Notice: Array to string conversion in ROOT/libraries/joomla/table/nested.php on line 985
[02-Nov-2016 16:24:32 UTC] PHP Notice: Undefined variable: ntext in ROOT/libraries/legacy/controller/admin.php on line 237
Patch and test again.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
mbabker
- comment
- 3 Nov 2016
Fixed this one...
brianteeman
- comment
- 3 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12737.
| Status | Pending | ⇒ | Ready to Commit |
jeckodevelopment
- comment
- 3 Nov 2016
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12737.
infograf768
- comment
- 4 Nov 2016
RTC. Thanks for testing
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12737.
rdeutz
- | Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-04 09:44:01 |
| Closed_By | ⇒ | rdeutz |
Tested successfully
@mbabker missing sha again ;( )
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12737.