Feeling Lucky
[#1273] - JTable::load() should always return false if row wasn't loaded
- Closed
- 22 Dec 2014
- Medium
- Build: master
- # 1273
- Diff
- mahagr:bug-jtable
- Error default This pull request is targeted at the master branch. Pull requests should no longer be merged to master. Details
User tests: Successful: Unsuccessful:
Current version of JTable::load(null) returns true if table key is either null or 0. This contradicts the method documentation which says that false is returned if the row wasn't found (from the database).
// Initialize any table instance (with id as primary key) and run:
$table->id = 0;
$success = $table->load();
var_dump($success); // true (should be false)
$table->id = 9999999;
$success = $table->load();
var_dump($success); // false
mahagr
- comment
- 17 Oct 2013
| Status | New | ⇒ | Pending |
| Build | ⇒ | . |
| Category | ⇒ | Libraries |
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2014-12-22 20:17:59 |
wilsonge
- comment
- 24 Dec 2014
Reverted for now
Thanks for your contribution - At this time we are only using github as the place to submit code fixes, the actual reporting of issues and testing fixes is still taking place on Joomlacode.
As it has been some time since you opened this issue can you please confirm that it is still valid with the current Master or Joomla 3.2 beta. If it is no longer valid then please can you close this issue. Otherwise please can you:
1) Open an item on the Joomlacode tracker in the appropriate area.
CMS Bug Reports: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8103
CMS Feature Requests: http://joomlacode.org/gf/project/joomla/tracker/?action=TrackerItemBrowse&tracker_id=8549
2) After submitting the item to the Joomlacode tracker, add a link to the Joomlacode tracker item here and make sure that you add a link to this GitHub issue or pull request on the joomlacode tracker item.