Feeling Lucky
?
[#12729] - [com_fields] Fix notices in contact view
- Fixed in Code Base
- 5 Nov 2016
- Medium
- Build: staging
- # 12729
- Diff
- Bakual:FixNoticesContactFields
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12728
Summary of Changes
-
render_classis a param, not an object property. - The
$fieldsarray doesn't always start with the key0. This PR usesresetto get the first item.
Testing Instructions
- Create multiple custom fields for contacts and set the "edit value" permissions so it is allowed by public. Set the fields to different positions (unter tab options -> automatic display)
- Edit a contact to add some value to those fields.
- View that contact in frontend.
Before PR you get multiple notices after PR they are gone.
Documentation Changes Required
None
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Front End Components |
| Title |
|
||||||
AnnemiekStoel
- comment
- 4 Nov 2016
I have tested this item
Test succesful
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12729.
| Milestone |
Added: |
||
| Status | Pending | ⇒ | Ready to Commit |
| Milestone |
Added: |
||
zero-24
- comment
- 4 Nov 2016
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12729.
rdeutz
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-05 09:26:27 |
| Closed_By | ⇒ | rdeutz |
I have tested this item✅ successfully on 188cfeb
Notices where gone after patch install
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12729.