Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#12723] - [com_fields] Use JComponentHelper::getParams() instead of JComponentHelper::getComponent('com_foo')->params

? Pending

User tests: Successful: Unsuccessful:

avatar Bakual
Bakual
3 Nov 2016

Summary of Changes

This PR simplifies com_fields code a bit by changing the useage of JComponentHelper::getComponent('com_foo')->params to JComponentHelper::getParams('com_foo')

Just proper use of existing API

Testing Instructions

Test that the com_fields links in the sidebar appear as expected.
Test that the backend menu items under "Content" for com_fields appear as expected.

Documentation Changes Required

None

avatar Bakual Bakual - open - 3 Nov 2016
avatar Bakual Bakual - change - 3 Nov 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Nov 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 3 Nov 2016
Category ⇒ Administration Components Modules
avatar Bakual Bakual - change - 3 Nov 2016
Title
…
Use JComponentHelper::getParams()
[com_fields] Use JComponentHelper::getParams() instead of ComponentHelper::getComponent('com_foo')->params
avatar Bakual Bakual - change - 3 Nov 2016
Title
…
Use JComponentHelper::getParams()
[com_fields] Use JComponentHelper::getParams() instead of ComponentHelper::getComponent('com_foo')->params
avatar Bakual Bakual - edited - 3 Nov 2016
avatar laoneo
laoneo - comment - 3 Nov 2016

Tested it successfully, but got the missing SHA error.

avatar andrepereiradasilva andrepereiradasilva - test_item - 3 Nov 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 3 Nov 2016

I have tested this item ✅ successfully on 3bb215e

on code review

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12723.

avatar wilsonge wilsonge - change - 3 Nov 2016
Title
…
[com_fields] Use JComponentHelper::getParams() instead of ComponentHelper::getComponent('com_foo')->params
[com_fields] Use JComponentHelper::getParams() instead of JComponentHelper::getComponent('com_foo')->params
avatar wilsonge wilsonge - edited - 3 Nov 2016
avatar wilsonge wilsonge - change - 3 Nov 2016
Title
…
[com_fields] Use JComponentHelper::getParams() instead of ComponentHelper::getComponent('com_foo')->params
[com_fields] Use JComponentHelper::getParams() instead of JComponentHelper::getComponent('com_foo')->params
avatar wilsonge wilsonge - reference | 0dd0740 - 3 Nov 16
avatar wilsonge wilsonge - merge - 3 Nov 2016
avatar wilsonge wilsonge - change - 3 Nov 2016
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-11-03 14:40:58
Closed_By ⇒ wilsonge
avatar wilsonge wilsonge - close - 3 Nov 2016
avatar wilsonge wilsonge - merge - 3 Nov 2016
avatar wilsonge wilsonge - close - 3 Nov 2016
avatar wilsonge wilsonge - close - 3 Nov 2016
avatar wilsonge wilsonge - change - 3 Nov 2016
Milestone Added:

Add a Comment

Login with GitHub to post a comment