[#12708] - shorten label in global configuration
- Fixed in Code Base
- 3 Nov 2016
- Medium
- Build: staging
- # 12708
- Diff
- brianteeman:sitename
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12706 .
Summary of Changes
This is purely a cosmetic change to maintain alignment
As noted in the report this will not help for non-english languages but thats a bigger problem effecting all labels and wont help with squashed views on smaller screens
Before
After
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
?
|
||
| Category | ⇒ | Administration Language & Strings |
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12708.
What about the overlapping issue of the columns in smaller screens ? mentioned by #12706
why not add a sane minimum width to force wrap just before overlapping occurs ?
e.g.
#config-document .span6 {
min-width: 400px;
}or even better a media css rule:
@media (max-width: 1023px) {
#config-document .span6 {
width: 100%;
}
}
If you have to override the widths set by Bootstrap's grid system you've messed up catastrophically.
This is not a general override for bootstrap !!
- we have a specific page that has specific needs for width for the columns
I did not suggest a terrible general rule like
@media (max-width: 1023px) {
.span6 {
width: 100%;
}
}Imagine having a class that extends a class and not be allowed to customize its code according to specific needs,
bootstrap CSS rules are not sacred, and if they are proper for all cases, why do they fail terribly in this case ? of course any CSS override must be made sure that it will only effect other pages
The alternative CSS to fix this will be even uglier overrides ! with uglier looking result,
of course in the end you can just remove the columns, but wait my suggested code does exactly this, it forces 1 column at a sane width limit
If you have to override the widths set by Bootstrap's grid system you've messed up catastrophically.
but there is also a good point to the above too
So to make it even safer / neater, we can introduce a new CSS class, that will be added along with span6 or at container id="config-document", (that is what i do)
That's an issue that effects all screens especially the modals
Thanks
| Status | Pending | ⇒ | Ready to Commit |
| Labels | |||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12708.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-03 00:39:01 |
| Closed_By | ⇒ | zero-24 | |
| Labels |
Added:
?
|
||
Thanks
| Labels |
Removed:
?
|
||
| Milestone |
Added: |
||
I have tested this item✅ successfully on 73ff6eb
on code review
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12708.