?
avatar brianteeman
brianteeman
2 Nov 2016

Steps to reproduce the issue

If i am correct then we are using different terms for the same thing

Here
New URL and Destination URL are the same

ditq

Here
Source URL and Destination URL refers to Expired URL and New URL in the manager screen
image

Have I got that right? If so then we need to be consistent and just use one term for the same thing

avatar brianteeman brianteeman - open - 2 Nov 2016
avatar joomla-cms-bot joomla-cms-bot - change - 2 Nov 2016
Labels Added: ?
avatar brianteeman brianteeman - change - 3 Nov 2016
Category com_redirect Language & Strings
avatar brianteeman
brianteeman - comment - 14 Nov 2016

Also source URL and expired URL are the same thing


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12700.

avatar brianteeman
brianteeman - comment - 14 Nov 2016

Also source URL and expired URL are the same thing


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12700.

avatar tonypartridge
tonypartridge - comment - 2 Dec 2016

Yes that's right, we have always used source URL and destination URL but that is a little confusing. I suggest we us:

Expired URL:
New URL:

Since it has to be a 404 to redirect.

avatar zero-24
zero-24 - comment - 2 Dec 2016

Can you send a PR for that change than?

avatar tonypartridge
tonypartridge - comment - 3 Dec 2016

Sure will do

avatar tonypartridge
tonypartridge - comment - 5 Dec 2016

PR sent: #13090

avatar brianteeman
brianteeman - comment - 5 Dec 2016

Closed as we have a pr

avatar brianteeman brianteeman - change - 5 Dec 2016
Status New Closed
Closed_Date 0000-00-00 00:00:00 2016-12-05 11:51:31
Closed_By brianteeman
avatar brianteeman brianteeman - close - 5 Dec 2016

Add a Comment

Login with GitHub to post a comment