[#12688] - Fix double parameters creation for parameters of home template and of template override
- Fixed in Code Base
- 3 Nov 2016
- Medium
- Build: staging
- # 12688
- Diff
- ggppdk:patch-26
- Success continuous-integration/drone the build was successful Details
- Success continuous-integration/travis-ci/pr The Travis CI build passed Details
- Success JTracker/HumanTestResults Human Test Results: 2 Successful 0 Failed. Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #12651
Summary of Changes
The home template styles are cloned, inside the foreach loop (see the modified code) and then added to the same array: $templates
as $templates[0]
thus parameters creation for template home: $templates[0]
will happen twice
Testing Instructions
Styles are applied as configured
Documentation Changes Required
none
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Labels |
Added:
?
|
||
| Category | ⇒ | Libraries |
@SharkyKZ
Thanks, i have fixed that case too with last commt:
The array $templates, already has parameters created for all template
then we select just template override, there is no reason to try to create parameters again
@Espionage724 @csiteru
Please test
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12688.
| Title |
|
||||||
I have tested this item
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12688.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12688.
| Labels |
Added:
?
|
||
| Milestone |
Added: |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2016-11-03 16:50:08 |
| Closed_By | ⇒ | zero-24 |
Thanks!
| Labels |
Removed:
?
|
||
Hi!
I found the bug why the template style always is set default on my site on j3.6.4.
When SEF is off, in https://github.com/joomla/joomla-cms/blob/5b4816f32aa4f773a78ae4d302dd4c38dff9d8f5/libraries/cms/application/site.php#L440 is set right ItemId and template is set right. But is SEF is ON, This function returns 0 and $id set = 0 in line 448 ($id = $item->template_style_id). Thats why
$template = $templates[$id]; is always = 0, and template style set defaunt.
https://github.com/joomla/joomla-cms/blob/5b4816f32aa4f773a78ae4d302dd4c38dff9d8f5/libraries/cms/application/site.php#L506
Yes please open a new issue with that video than :)
PhilETaylor
- 
nvyush
- 
Does anyone have a fix when using a T3 template with two assigned styles running on 3.6.4? I have a logged in area I need to use a different template / menu system on but it is always displaying the default template when seo is turned on. Thanks
I suggest that you contact t3 diectly as we can only support issues in the
Joomla core
On 10 November 2016 at 15:52, Lee Tempest notifications@github.com wrote:
Does anyone have a fix when using a T3 template with two assigned styles
running on 3.6.4? I have a logged in area I need to use a different
template / menu system on but it is always displaying the default template
when seo is turned on. Thanks—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#12688 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8eNJbKKwHB_mx1wT-dWrN0gTTjPAks5q8y-qgaJpZM4Kmly9
.
Brian Teeman
Co-founder Joomla! and OpenSourceMatters Inc.
https://brian.teeman.net/ http://brian.teeman.net/
Default template seems to work fine but setting template via URL does not, params are still missing.