Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#12684] - add support for user.js to beez and protostar

? Success

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
1 Nov 2016

Pull Request for Issue #12683 .

Summary of Changes

We have support for user.css - this adds support or an equivalent js file

Testing Instructions

Create a user.js file with some content in /templates/beez3/js
Create a user.js file with some content in /templates/protostar/js
and check that they are loaded

Remove the user.js files and check that the template is not trying to load them

avatar brianteeman brianteeman - open - 1 Nov 2016
avatar brianteeman brianteeman - change - 1 Nov 2016
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2016
Labels Added: ?
avatar joomla-cms-bot joomla-cms-bot - change - 1 Nov 2016
Category ⇒ Front End Templates (site)
avatar brianteeman
brianteeman - comment - 1 Nov 2016

Thanks I will check later. It should just have been a copy paste of the
existing css code

On 1 Nov 2016 12:22 p.m., "Georgios Papadakis" notifications@github.com
wrote:

@ggppdk commented on this pull request.

In templates/beez3/index.php
#12684 (comment)
:

@@ -85,6 +85,14 @@
$this->addScript($this->baseurl . '/templates/' . $this->template . '/javascript/respond.src.js');
$this->addScript($this->baseurl . '/templates/' . $this->template . '/javascript/template.js');

+// Check for a custom js file
+$userJs = JPATH_SITE . '/templates/' . $this->template . '/js/user.js';
+
+if (file_exists($userJs && filesize($userJs) > 0)

This code open 3 parenthesis and closes 2 ?
I think, you meant something like:

if ( JFile::exists($userJs) && filesize($userJs))

Same for the other file

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#12684 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABPH8X3GFduKu8_YzePWHMpBchWuJWLiks5q5y8hgaJpZM4KmBrI
.

avatar brainforgeUK
brainforgeUK - comment - 1 Nov 2016

Should this be included with ISIS and other admin templates?
See #12683 referred to above.

avatar brianteeman
brianteeman - comment - 1 Nov 2016

Personally I don't see the need for this in the admin.

avatar ghazal ghazal - test_item - 2 Nov 2016 - Tested successfully
avatar ghazal
ghazal - comment - 2 Nov 2016

I have tested this item ✅ successfully on d39ed90

Being a heavy JS user, I really appreciate this.

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12684.

avatar andrepereiradasilva andrepereiradasilva - test_item - 2 Nov 2016 - Tested successfully
avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Nov 2016

I have tested this item ✅ successfully on fc0e382

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12684.

avatar brianteeman
brianteeman - comment - 2 Nov 2016

Updated with version code from @andrepereiradasilva

avatar andrepereiradasilva
andrepereiradasilva - comment - 2 Nov 2016

@ghazal you need to retest after latest changes

avatar ghazal ghazal - test_item - 3 Nov 2016 - Tested successfully
avatar ghazal
ghazal - comment - 3 Nov 2016

I have tested this item ✅ successfully on fc0e382

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12684.

avatar zero-24 zero-24 - change - 3 Nov 2016
Status Pending ⇒ Ready to Commit
avatar zero-24
zero-24 - comment - 3 Nov 2016

RTC cc: @rdeutz

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/12684.

avatar joomla-cms-bot joomla-cms-bot - change - 3 Nov 2016
Labels Added: ?
avatar rdeutz
rdeutz - comment - 3 Nov 2016

I might be wrong but the usual convention for a javascript directory is "js"

avatar brianteeman
brianteeman - comment - 3 Nov 2016

It is but you will see that beez is called /javascript/ and always has been - I guess you forgot

avatar rdeutz
rdeutz - comment - 3 Nov 2016

ah getting old :-)

avatar rdeutz rdeutz - close - 3 Nov 2016
avatar rdeutz rdeutz - merge - 3 Nov 2016
avatar rdeutz rdeutz - close - 3 Nov 2016
avatar joomla-cms-bot joomla-cms-bot - close - 3 Nov 2016
avatar rdeutz rdeutz - change - 3 Nov 2016
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2016-11-03 17:28:26
Closed_By ⇒ rdeutz
avatar brianteeman
brianteeman - comment - 3 Nov 2016

Thanks

avatar joomla-cms-bot joomla-cms-bot - change - 3 Nov 2016
Labels Removed: ?

Add a Comment

Login with GitHub to post a comment